Repository navigation
Install correct geckodriver binary on arm64 Linux - #19
Merged
Merged
Conversation
On arm64 Linux, install.js silently fell through to the x86 fallback and downloaded the 32-bit Linux build. That binary then failed at runtime with "Exec format error", which surfaced downstream as selenium reporting "Server terminated early with status 2" — the kind of error that's hard to trace back here. arm64 Linux runners are increasingly common (CI on GitHub-hosted arm64, sitespeed.io's multi-arch container), so it's worth handling explicitly the same way the darwin branch already does. The Linux CI workflow also only ran npm ci and never executed the downloaded driver, which is why this slipped through. Adding npm test plus an arm64 runner to the matrix verifies the installed binary actually runs. Co-authored-by: Claude noreply@anthropic.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On arm64 Linux, install.js silently fell through to the x86 fallback and
downloaded the 32-bit Linux build. That binary then failed at runtime
with "Exec format error", which surfaced downstream as selenium
reporting "Server terminated early with status 2" — the kind of error
that's hard to trace back here. arm64 Linux runners are increasingly
common (CI on GitHub-hosted arm64, sitespeed.io's multi-arch container),
so it's worth handling explicitly the same way the darwin branch
already does.
The Linux CI workflow also only ran npm ci and never executed the
downloaded driver, which is why this slipped through. Adding npm test
plus an arm64 runner to the matrix verifies the installed binary
actually runs.
Co-authored-by: Claude noreply@anthropic.com