Repository navigation
Trim runtime dependencies - #18
Merged
Merged
Conversation
Drop node-stream-zip and bump tar to 7.5.15. The only place
node-stream-zip was used was extracting the Windows geckodriver
release, which is a .zip; Windows 10 build 17063 (April 2018) and
later ships bsdtar as tar.exe and extracts .zip in place, so a
tar -xf shell-out replaces the dependency. macOS and Linux still go
through the tar package for .tar.gz.
Why: keeps the install surface small. node-stream-zip hasn't shipped
since 2022 and pulling it in just for one OS's archive format was
hard to justify when system tar is already there.
How to apply: tar 7 is dual ESM/CJS but only ships named exports, so
the import switches from import tar from 'tar' to
import { x as extractTar } from 'tar'.
Co-authored-by: Claude noreply@anthropic.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop node-stream-zip and bump tar to 7.5.15. The only place
node-stream-zip was used was extracting the Windows geckodriver
release, which is a .zip; Windows 10 build 17063 (April 2018) and
later ships bsdtar as tar.exe and extracts .zip in place, so a
tar -xf shell-out replaces the dependency. macOS and Linux still go
through the tar package for .tar.gz.
Why: keeps the install surface small. node-stream-zip hasn't shipped
since 2022 and pulling it in just for one OS's archive format was
hard to justify when system tar is already there.
How to apply: tar 7 is dual ESM/CJS but only ships named exports, so
the import switches from import tar from 'tar' to
import { x as extractTar } from 'tar'.
Co-authored-by: Claude noreply@anthropic.com