Skip to content

[feat] Add support for TypeScript scripts, changing engineUtils.js#2363

Open
kormanowsky wants to merge 3 commits intositespeedio:mainfrom
kormanowsky:patch-1
Open

[feat] Add support for TypeScript scripts, changing engineUtils.js#2363
kormanowsky wants to merge 3 commits intositespeedio:mainfrom
kormanowsky:patch-1

Conversation

@kormanowsky
Copy link

Node.js now supports TypeScript (see https://nodejs.org/api/typescript.html). Adding support for it in sitespeed/browseritime scripts.

Node.js now supports TypeScript (see https://nodejs.org/api/typescript.html). Adding support for it in sitespeed/browseritime scripts.
@soulgalore
Copy link
Member

Hi @kormanowsky thanks, could you also please add a typescript version of a script and a test that runs in one of the GitHub actions https://github.com/sitespeedio/browsertime/tree/main/.github/workflows ? That helps me make sure the support isn't broken,

@kormanowsky
Copy link
Author

Hi @kormanowsky thanks, could you also please add a typescript version of a script and a test that runs in one of the GitHub actions https://github.com/sitespeedio/browsertime/tree/main/.github/workflows ? That helps me make sure the support isn't broken,

Hi @soulgalore
Sure, will add a sample script and a test soon

And I have a question — what should we do with failing checks? They don’t seem to fail because of my changes..

@kormanowsky
Copy link
Author

Added tests @soulgalore

@kormanowsky
Copy link
Author

@soulgalore could you please restart the tests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants