Skip to content

fix: stop intercepting plain c in auth shell#615

Open
CoderLuii wants to merge 2 commits intositeboon:mainfrom
CoderLuii:fix/shell-auth-copy-shortcut
Open

fix: stop intercepting plain c in auth shell#615
CoderLuii wants to merge 2 commits intositeboon:mainfrom
CoderLuii:fix/shell-auth-copy-shortcut

Conversation

@CoderLuii
Copy link
Copy Markdown

@CoderLuii CoderLuii commented Apr 4, 2026

Summary

  • stop consuming plain lowercase c in the minimal auth shell path
  • keep the auth URL copy shortcut on an explicit Shift+C chord instead

Testing

  • validated in HolyClaude integration flow while reproducing the broken plain-text c input issue

Summary by CodeRabbit

  • Bug Fixes
    • Updated the keyboard shortcut for copying authentication URLs in the shell terminal. The shortcut now requires pressing Shift + C instead of the "c" key, preventing accidental triggers. Standard copy and paste shortcuts remain unaffected.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 4, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 2d822186-08d6-4a51-a5af-09c172053d90

📥 Commits

Reviewing files that changed from the base of the PR and between 388134c and 00b5d8f.

📒 Files selected for processing (1)
  • src/components/shell/hooks/useShellTerminal.ts

📝 Walkthrough

Walkthrough

Updated keyboard shortcut in the shell terminal hook from triggering on lowercase "c" to requiring Shift + "C" for initiating auth URL copy functionality in plain-shell flows.

Changes

Cohort / File(s) Summary
Keyboard Shortcut Update
src/components/shell/hooks/useShellTerminal.ts
Modified custom key handling to require Shift + "C" instead of case-insensitive "c" for auth URL copy trigger.

Poem

🐰 A shift was made, precise and keen,
Now "C" needs company, if you know what I mean!
Shift and uppercase dance in harmony,
Auth URLs copy with specificity!
The shell speaks clearer, as shells should be. ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title accurately describes the main change: switching from intercepting plain 'c' key to requiring Shift+C for the auth shell copy functionality.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant