Develop_Sprint_7 - #1
Open
sisizov-dev wants to merge 44 commits into
Open
Conversation
| ("password", {"login": "test_courier", "password": ""}) # нет пароля | ||
| ] | ||
|
|
||
| # Генераторы случайных данных |
There was a problem hiding this comment.
Нужно исправить: здесь и далее в модуле с данными должны храниться только статичные данные. Генераторы - в helpers
| import allure | ||
| import requests | ||
|
|
||
| BASE_URL = "https://qa-scooter.praktikum-services.ru/api/v1" |
There was a problem hiding this comment.
Можно улучшить: здесь и далее урл лучше хранить отдельно
| assert response.status_code == 409, f"Ожидался код 409, получен {response.status_code}" | ||
|
|
||
| with allure.step("Проверяем текст ошибки"): | ||
| expected_message = "Этот логин уже используется. Попробуйте другой." |
There was a problem hiding this comment.
Можно улучшить: здесь и далее тексты сообщений тоже лучше хранить отдельно
| login, password, first_name = register_new_courier_and_return_login_password() | ||
|
|
||
| # Если регистрация не удалась, логин будет пустым | ||
| if not login: |
There was a problem hiding this comment.
Нужно исправить: в тестах не должно быть условий
| if not login: | ||
| pytest.fail("Не удалось создать курьера для теста") | ||
|
|
||
| return login, password, first_name No newline at end of file |
There was a problem hiding this comment.
Нужно исправить: фикстура, создающая курьера, должна его удалять
| delete_courier(courier_id) | ||
| # Проверка, что курьер удалён | ||
| login_after = login_courier({"login": login, "password": password}) | ||
| assert login_after.status_code == 404, "Курьер не был удалён" |
There was a problem hiding this comment.
Нужно исправить: в фикстурах не должно быть assert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.