Skip to content

Fix false 'incomplete entity data' warning for HDF5 files #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chraibi wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix false 'incomplete entity data' warning for HDF5 files #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 24 additions & 12 deletions ...older/ProjectMobius/Source/ProjectMobius/Private/MassAI/SubSystems/AgentDataSubsystem.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1298,11 +1298,6 @@ void FProcessSimulationDataRunnable::RunHdf5SimDataGatheringLoop(bool bCalculate

// --- Incomplete data detection ---
int32 ActualTimestepCount = MaxTimestepIndex + 1;
int32 PeakEntityCount = 0;
for (int32 Count : NumOfAgentsPerTimeStep)
{
PeakEntityCount = FMath::Max(PeakEntityCount, Count);
}

// Timestep mismatch: metadata says more timesteps than we actually loaded
if (Hdf5Data.Meta.Duration > 0 && Hdf5Data.Meta.SamplingRate > 0)
Expand All @@ -1318,14 +1313,31 @@ void FProcessSimulationDataRunnable::RunHdf5SimDataGatheringLoop(bool bCalculate
}
}

// Entity count mismatch: fewer entities observed than metadata declares
if (MaxAgents > 0 && PeakEntityCount > 0 && PeakEntityCount < MaxAgents)
// Entity coverage: every entity the metadata declares should appear in at least one
// timestep. This deliberately does not compare against the busiest timestep, because
// agents enter and leave over the course of a simulation, so the peak concurrent count
// is legitimately lower than the total number of distinct entities.
if (MaxAgents > 0)
{
ReportAgentDataErrorAnyThread(OwnerSubsystem.Get(),
TEXT("Incomplete entity data"),
FString::Printf(TEXT("HDF5: peak entity count %d < MaxAgents %d. Some entities may be missing."),
PeakEntityCount, MaxAgents),
TEXT("AgentDataSubsystem - RunHdf5SimDataGatheringLoop"));
TBitArray<> ObservedEntities(false, MaxAgents);
int32 ObservedEntityCount = 0;
for (const FHdf5SampleData& Sample : Hdf5Data.Samples)
{
if (ObservedEntities.IsValidIndex(Sample.EntityId) && !ObservedEntities[Sample.EntityId])
{
ObservedEntities[Sample.EntityId] = true;
++ObservedEntityCount;
}
}

Comment on lines +1323 to +1332
if (ObservedEntityCount < MaxAgents)
{
ReportAgentDataErrorAnyThread(OwnerSubsystem.Get(),
TEXT("Incomplete entity data"),
FString::Printf(TEXT("HDF5: %d of %d entities have no samples. Data may be incomplete."),
MaxAgents - ObservedEntityCount, MaxAgents),
TEXT("AgentDataSubsystem - RunHdf5SimDataGatheringLoop"));
}
}
}

Expand Down
Loading