Skip to content

Bump Microsoft.NET.Test.Sdk from 18.10.1 to 18.11.0 - #450

Merged
sir-gon merged 1 commit into
mainfrom
dependabot/nuget/src/algorithm_exercises_csharp_test/Microsoft.NET.Test.Sdk-18.11.0
Oct 13, 2026
Merged

Bump Microsoft.NET.Test.Sdk from 18.10.1 to 18.11.0#450
sir-gon merged 1 commit into
mainfrom
dependabot/nuget/src/algorithm_exercises_csharp_test/Microsoft.NET.Test.Sdk-18.11.0

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Oct 13, 2026

Copy link
Copy Markdown
Contributor

Updated Microsoft.NET.Test.Sdk from 18.10.1 to 18.11.0.

Release notes

Sourced from Microsoft.NET.Test.Sdk's releases.

18.11.0

What's Changed

New Contributors

Full Changelog: microsoft/vstest@v18.10.1...v18.11.0

Commits viewable in compare view.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot Bot added .NET Pull requests that update .net code dependencies Pull requests that update a dependency file labels Oct 13, 2026
@fossabot

fossabot Bot commented Oct 13, 2026 •
edited
Loading

Copy link
Copy Markdown

Needs Review

I recommend reviewing this upgrade before merging because it introduces two high-confidence breaking changes: the Microsoft Testing Platform (MTP) testhost is now disabled by default, and reflection-based deserialization setters have been removed. The codebase actively uses Microsoft.NET.Test.Sdk in the test project (algorithm_exercises_csharp_test.csproj), which also references MSTest.TestAdapter and MSTest.TestFramework v4.5.1 — a combination that makes the MTP testhost default-off change directly relevant, as MSTest v4 supports MTP mode and the behavioral shift may affect test discovery and execution. Compounding this, the CI workflow runs tests against .NET 10.x, and documentation confirms that VSTest-based test execution is no longer supported on .NET 10 SDK by Microsoft.Testing.Platform — disabling MTP by default could push execution toward VSTest on a runtime where VSTest is unsupported. Additionally, the security/snyk external CI check is failing, and without access to its logs, the cause cannot be ruled out as related to this upgrade. On the positive side, the upgrade ships 18 bug fixes and 2 new features, and the release includes security-hardening improvements to the SDK's own build pipeline (GitHub Actions SHA-pinning and signing validation re-enablement). Teams should validate test execution across all target runtimes — especially .NET 10 — before merging.

Tip: Comment @​fossabot fix to attempt automatic fixes.

Fix Suggestions

We identified 3 fixable issues in this upgrade.

  • Add <EnableMicrosoftTestingPlatform>true</EnableMicrosoftTestingPlatform> property to the test project to re-enable MTP testhost, which was disabled by default in Microsoft.NET.Test.Sdk 18.11.0
    Files: src/algorithm_exercises_csharp_test/algorithm_exercises_csharp_test.csproj
  • Validate test execution across all CI matrix entries (net8.0, net9.0, net10.0) after applying the MTP re-enablement fix to confirm no regressions
    Files: .github/workflows/dotnet-test.yml, src/algorithm_exercises_csharp_test/algorithm_exercises_csharp_test.csproj
  • Investigate the failing security/snyk external CI check to determine if it is related to the Microsoft.NET.Test.Sdk 18.11.0 upgrade

AI Assistant Prompt

Copy prompt for AI assistant 
# Fix Microsoft.NET.Test.Sdk 18.11.0 Upgrade Issues

## Context
We upgraded `Microsoft.NET.Test.Sdk` from a previous version to **18.11.0** in PR #450. This version introduces a breaking change: the **Microsoft Testing Platform (MTP) testhost is now disabled by default**. Our CI matrix runs tests on **.NET 8.0.x, 9.0.x, and 10.0.x**, and VSTest-based test execution is **no longer supported on .NET 10 SDK**. This means without explicitly enabling MTP, tests will fail on .NET 10.

Our test project uses **MSTest v4.5.1** (`MSTest.TestAdapter` + `MSTest.TestFramework`), which supports MTP mode.

## Fix Required

### File: `src/algorithm_exercises_csharp_test/algorithm_exercises_csharp_test.csproj`

Add the `<EnableMicrosoftTestingPlatform>true</EnableMicrosoftTestingPlatform>` property inside the first `<PropertyGroup>` to re-enable the MTP testhost.

The current file looks like this:

```xml
<Project Sdk="Microsoft.NET.Sdk">

  <PropertyGroup>
    <TargetFramework>net8.0</TargetFramework>
    <RootNamespace>algorithm_exercises_csharp_test</RootNamespace>
    <ImplicitUsings>enable</ImplicitUsings>
    <Nullable>enable</Nullable>

    <IsPackable>false</IsPackable>
    <IsTestProject>true</IsTestProject>

    <SonarQubeTestProject>true</SonarQubeTestProject>

    <!-- Coverage -->
    <CollectCoverage>true</CollectCoverage>
    <CoverletOutputFormat>lcov,opencover</CoverletOutputFormat>
    <IncludeTestAssembly>true</IncludeTestAssembly>
    <ExcludeByAttribute>TestSDKAutoGeneratedCode</ExcludeByAttribute>

    <!-- Code analysis. -->
    <EnableNETAnalyzers>true</EnableNETAnalyzers>
    <AnalysisLevel>latest</AnalysisLevel>
    <AnalysisMode>All</AnalysisMode>
    <EnforceCodeStyleInBuild>true</EnforceCodeStyleInBuild>

  </PropertyGroup>
  ...
</Project>
```

Please add the following property after `<IsTestProject>true</IsTestProject>` (around line 10):

```xml
    <!-- Enable Microsoft Testing Platform (required for .NET 10+ where VSTest is unsupported) -->
    <EnableMicrosoftTestingPlatform>true</EnableMicrosoftTestingPlatform>
```

### Why This Fix Is Needed
1. **Microsoft.NET.Test.Sdk 18.11.0** disabled the MTP testhost by default (breaking change)
2. **VSTest is not supported on .NET 10 SDK** by Microsoft.Testing.Platform
3. Our CI workflow (`.github/workflows/dotnet-test.yml`) runs `dotnet test` across .NET 8.0.x, 9.0.x, and **10.0.x** — without MTP enabled, test discovery and execution will fail on .NET 10
4. MSTest v4.5.1 fully supports MTP mode, so enabling this property is the correct fix

### Post-Fix Validation
After making this change, verify that `dotnet test --no-build --verbosity normal` succeeds on all target frameworks, especially .NET 10. The CI workflow already tests across all three SDK versions in the matrix.

Please make only the `.csproj` change described above — no other files need modification for this fix.

What we checked

  • Microsoft.NET.Test.Sdk is explicitly referenced in the test project at version 18.11.0, confirming this package is actively used and the breaking changes in this release directly affect test execution. [1]
  • MSTest.TestAdapter v4.5.1 is referenced alongside Microsoft.NET.Test.Sdk. MSTest v4 supports Microsoft Testing Platform (MTP) mode; the breaking change disabling MTP testhost by default in this SDK version may alter how tests are discovered and executed. [2]
  • The test project targets net8.0, but CI runs tests against dotnet-version: [8.0.x, 9.0.x, 10.0.x] (see .github/workflows/dotnet-test.yml line 35), meaning test execution under .NET 10 SDK is in scope. Disabling MTP by default risks falling back to VSTest, which is no longer supported on .NET 10 SDK by Microsoft.Testing.Platform. [3]
  • CI matrix includes 10.0.x as a target .NET SDK version, making the MTP-vs-VSTest behavioral change directly relevant to CI stability under this upgrade. [4]
  • High-confidence breaking change (changelog + release notes): Disable the MTP testhost by default (#16337). The Microsoft Testing Platform testhost is no longer enabled by default, which changes the test execution pipeline for projects using MSTest v4 in MTP mode. [5]
  • Microsoft documentation confirms that dotnet test fails on .NET 10 SDK projects with the error 'Testing with VSTest target is no longer supported by Microsoft.Testing.Platform on .NET 10 SDK and later'. Disabling MTP by default in this upgrade could surface this failure for the 10.0.x CI matrix entry. [6]
  • MSTest v4 migration guide confirms behavioral changes around Microsoft.NET.Test.Sdk interaction: the implicit SDK reference in MTP mode was removed in MSTest v4. Since the project explicitly references Microsoft.NET.Test.Sdk, this specific migration concern is handled — but the MTP-default-off behavior still requires validation. [7]

Dependency Usage

No usage of the analyzed dependencies was found in this repository.

View 2 more usages

Changes

Microsoft.NET.Test.Sdk was updated with 2 security fixes (pinning GitHub Actions to full-length commit SHAs and re-enabling signing validation) and 3 breaking changes: the MTP testhost is now disabled by default, and reflection-based deserialization setters have been removed. Additionally, 18 bug fixes were included, notably correcting TRX logger corruption of non-BMP Unicode characters, fixing VSTestCLIRunSettings backslash normalization on Unix, and improving logger concurrency and write reliability.

View 45 more changes
  • Pin GitHub Actions to full-length commit SHAs (#16338) (7a6c166) (v18.11.0, changelog)
  • Re-enable official signing validation (#16364) (d52fd7f) (v18.11.0, changelog)
  • Fix false positives in the markdown link checker (#16312) (5c6dc58) (v18.11.0, changelog)
  • Bump Microsoft.VisualStudio.Diagnostics.Utilities to a release-branch build to fix SymbolCheck (main) (#16323) (252890f) (v18.11.0, changelog)
  • Quote left side of MSBuild condition expressions (#16325) (f7d5f02) (v18.11.0, changelog)
  • Fix TRX logger mangling astral-plane (non-BMP) characters (#16318) (e331e3b) (v18.11.0, changelog)
  • Address review comments from the TRX astral-plane fix (#16318) (#16335) (65de785) (v18.11.0, changelog)
  • Fix OS-blind apphost probe in MTP bridge (regression from #16201) (#16336) (384428e) (v18.11.0, changelog)
  • Fix logger concurrency correctness and TRX write reliability (#16326) (17c14fe) (v18.11.0, changelog)
  • Fix MsCoverageReferencedPathMaps: skip during design-time builds and add BuildInParallel (#16043) (ae77b29) (v18.11.0, changelog)
  • Pass arguments to PowerShell with -File instead of -command (#16363) (7e06f03) (v18.11.0, changelog)
  • Fix the single-test command in AGENTS.md that eng/build.ps1 rejects (#16387) (6b5328f) (v18.11.0, changelog)
  • [fix] Fix backslash normalization in VSTestCLIRunSettings on Unix (#15795) (499c9af) (v18.11.0, changelog)
  • Guard against a missing PATH in the NativeAOT publish test (#16380) (daac823) (v18.11.0, changelog)
  • Align expert reviewer verdicts with safe outputs (#16381) (0b289d5) (v18.11.0, changelog)
  • Skip the diagnostic test results publish when there is nothing to publish (#16401) (3941969) (v18.11.0, changelog)
  • Respect console logger verbosity from a settings file (#16044) (5193be4) (v18.11.0, changelog)
  • [link-checker] Fix broken v16.5.0 compare link in releases.md (#16313) (7255fd2) (v18.11.0, changelog)
  • Branding as 18.11.0 (#16314) (634d097) (v18.11.0, changelog)
  • Update reviewer team ID in Azure pipeline config (#16321) (f73598e) (v18.11.0, changelog)
  • Recompile expert reviewer workflow lock (#16324) (262a9dd) (v18.11.0, changelog)
  • [main] Update dependencies from dotnet/arcade (#16310) (6411dc2) (v18.11.0, changelog)
  • Restore custom data collector platform tests (#16354) (d8f6af1) (v18.11.0, changelog)
  • Revive socket client and server tests (#16348) (a3b36a6) (v18.11.0, changelog)
  • Simplify SocketServer: use is null and discard Task.Run result (#16361) (5210ceb) (v18.11.0, changelog)
  • Retarget the MTP client onto Microsoft.Testing.Platform.ServerMode.Client.Sources (#16300) (9cbb02d) (v18.11.0, changelog)
  • [main] Source code updates from dotnet/dotnet (#16334) (d2c19c0) (v18.11.0, changelog)
  • Simplify MTP code: combine or-patterns and use tuple deconstruction (#16369) (b207e49) (v18.11.0, changelog)
  • Remove two stale IDE0060 suppressions (#16373) (1faab3d) (v18.11.0, changelog)
  • Compile the MTP client out of source-only builds (#16385) (7e128f4) (v18.11.0, changelog)
  • Enable CA1310 and make culture-sensitive string comparisons ordinal (#16388) (0f5ac69) (v18.11.0, changelog)
  • docs: fix typo explicitely -> explicitly (#16397) (5bf95dc) (v18.11.0, changelog)
  • [main] Update dependencies from dotnet/arcade (#16368) (3470ed5) (v18.11.0, changelog)
  • Remove dead ExternalEnvironmentVariables left by #16116 (#16402) (9bdb396) (v18.11.0, changelog)
  • Copy acceptance test diagnostic logs into the test results directory (#16403) (d6dbc41) (v18.11.0, changelog)
  • Branding as 18.11.0-release (#16407) (7f981db) (v18.11.0, changelog)
  • Fix TRX logger mangling astral-plane (non-BMP) characters by @​azat-msft in https://redirect.github.com/microsoft/vstest/pull/16318 (v18.11.0, release notes)
  • Fix OS-blind apphost probe in MTP bridge on Unix (regression from #16201) by @​azat-msft in https://redirect.github.com/microsoft/vstest/pull/16336 (v18.11.0, release notes)
  • Pass arguments to PowerShell with -File instead of -command by @​nohwnd in https://redirect.github.com/microsoft/vstest/pull/16363 (v18.11.0, release notes)
  • Fix backslash normalization in VSTestCLIRunSettings on Unix by @​nohwnd in https://redirect.github.com/microsoft/vstest/pull/15795 (v18.11.0, release notes)
  • Respect console logger verbosity from a settings file by @​nohwnd in https://redirect.github.com/microsoft/vstest/pull/16044 (v18.11.0, release notes)
  • Retarget the MTP client onto Microsoft.Testing.Platform.ServerMode.Client.Sources by @​nohwnd in https://redirect.github.com/microsoft/vstest/pull/16300 (v18.11.0, release notes)
  • Docs: fix typo explicitely -> explicitly by @​vaibhav8a in https://redirect.github.com/microsoft/vstest/pull/16397 (v18.11.0, release notes)
  • Copy acceptance test diagnostic logs into the test results directory by @​nohwnd in https://redirect.github.com/microsoft/vstest/pull/16403 (v18.11.0, release notes)
  • @​vaibhav8a made their first contribution in https://redirect.github.com/microsoft/vstest/pull/16397 (v18.11.0, release notes)
References (7)

[1]: Microsoft.NET.Test.Sdk is explicitly referenced in the test project at version 18.11.0, confirming this package is actively used and the breaking changes in this release directly affect test execution.

algorithm-exercises-csharp/src/algorithm_exercises_csharp_test/algorithm_exercises_csharp_test.csproj

Line 40 in ac6c32f

<PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.11.0" />

[2]: MSTest.TestAdapter v4.5.1 is referenced alongside Microsoft.NET.Test.Sdk. MSTest v4 supports Microsoft Testing Platform (MTP) mode; the breaking change disabling MTP testhost by default in this SDK version may alter how tests are discovered and executed.

algorithm-exercises-csharp/src/algorithm_exercises_csharp_test/algorithm_exercises_csharp_test.csproj

Line 41 in ac6c32f

<PackageReference Include="MSTest.TestAdapter" Version="4.5.1" />

[3]: The test project targets net8.0, but CI runs tests against dotnet-version: [8.0.x, 9.0.x, 10.0.x] (see .github/workflows/dotnet-test.yml line 35), meaning test execution under .NET 10 SDK is in scope. Disabling MTP by default risks falling back to VSTest, which is no longer supported on .NET 10 SDK by Microsoft.Testing.Platform.

algorithm-exercises-csharp/src/algorithm_exercises_csharp_test/algorithm_exercises_csharp_test.csproj

Line 4 in ac6c32f

<TargetFramework>net8.0</TargetFramework>

[4]: CI matrix includes 10.0.x as a target .NET SDK version, making the MTP-vs-VSTest behavioral change directly relevant to CI stability under this upgrade.

algorithm-exercises-csharp/.github/workflows/dotnet-test.yml

Line 35 in ac6c32f

dotnet-version: [8.0.x, 9.0.x, 10.0.x]

[5]: High-confidence breaking change (changelog + release notes): Disable the MTP testhost by default (#16337). The Microsoft Testing Platform testhost is no longer enabled by default, which changes the test execution pipeline for projects using MSTest v4 in MTP mode. (source link)

[6]: Microsoft documentation confirms that dotnet test fails on .NET 10 SDK projects with the error 'Testing with VSTest target is no longer supported by Microsoft.Testing.Platform on .NET 10 SDK and later'. Disabling MTP by default in this upgrade could surface this failure for the 10.0.x CI matrix entry. (source link)

[7]: MSTest v4 migration guide confirms behavioral changes around Microsoft.NET.Test.Sdk interaction: the implicit SDK reference in MTP mode was removed in MSTest v4. Since the project explicitly references Microsoft.NET.Test.Sdk, this specific migration concern is handled — but the MTP-default-off behavior still requires validation. (source link)

fossabot analyzed this PR using dependency research and AI. View this analysis on the web

@fossabot

fossabot Bot commented Oct 13, 2026 •
edited
Loading

Copy link
Copy Markdown

fossabot is Thinking

@fossabot

fossabot Bot commented Oct 13, 2026 •
edited
Loading

Copy link
Copy Markdown

No Issues

No security issues were detected in the SAST scan. The code changes appear to follow secure coding practices.

fossabot analyzed this PR using SAST security analysis and AI (changed files only).

@codecov

codecov Bot commented Oct 13, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (6e0849a) to head (ac6c32f).

Additional details and impacted files 
@@            Coverage Diff            @@
##              main      #450   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           36        36           
  Lines          731       731           
  Branches        94        94           
=========================================
  Hits           731       731

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dependabot @sir-gon
Bump Microsoft.NET.Test.Sdk from 18.10.1 to 18.11.0
ac6c32f 
---
updated-dependencies:
- dependency-name: Microsoft.NET.Test.Sdk
  dependency-version: 18.11.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@sir-gon
sir-gon force-pushed the dependabot/nuget/src/algorithm_exercises_csharp_test/Microsoft.NET.Test.Sdk-18.11.0 branch from 19a8c8b to ac6c32f Compare October 13, 2026 21:55
@fossabot

fossabot Bot commented Oct 13, 2026 •
edited
Loading

Copy link
Copy Markdown

fossabot is Thinking

@fossabot

fossabot Bot commented Oct 13, 2026 •
edited
Loading

Copy link
Copy Markdown

No Issues

No security issues were detected in the SAST scan. The code changes appear to follow secure coding practices.

fossabot analyzed this PR using SAST security analysis and AI (changed files only).

@sonarqubecloud

sonarqubecloud Bot commented Oct 13, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@fossabot

fossabot Bot commented Oct 13, 2026 •
edited
Loading

Copy link
Copy Markdown

fossabot is Thinking

@sir-gon
sir-gon merged commit ffa7e32 into main Oct 13, 2026
76 of 77 checks passed
@dependabot
dependabot Bot deleted the dependabot/nuget/src/algorithm_exercises_csharp_test/Microsoft.NET.Test.Sdk-18.11.0 branch October 13, 2026 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file .NET Pull requests that update .net code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@sir-gon