Skip to content

improve workflows#2686

Merged
fatso83 merged 2 commits intosinonjs:mainfrom
till:improve-workflows
May 5, 2026
Merged

improve workflows#2686
fatso83 merged 2 commits intosinonjs:mainfrom
till:improve-workflows

Conversation

@till
Copy link
Copy Markdown
Contributor

@till till commented Apr 5, 2026

Purpose (TL;DR) - mandatory

This PR adds a couple improvements for the current workflows:

zizmor

zizmor is a neat tool enforce best practices for workflows, if there were any findings, it would creating security annotations via "github advanced security" (which is what the comment is about).

How to verify - mandatory

Approve the workflows, they should continue to run.

Checklist for author

  • npm run lint passes
  • References to standard library functions are cached.

till added 2 commits April 5, 2026 18:32
- pin all actions to precise commits
- avoid credential leakage from actions/checkout
- group action updates going forward
- add zimor config to ignore "secrets outside env"
- add job to keep validating workflows
@github-advanced-security
Copy link
Copy Markdown

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

fatso83
fatso83 previously requested changes Apr 9, 2026
Copy link
Copy Markdown
Contributor

@fatso83 fatso83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, commit specific commits seem a bit scary, TBH. I could live with specific versions, but maybe leave it at a specific tagged version?

Comment thread .github/workflows/main.yml
@fatso83 fatso83 dismissed their stale review May 5, 2026 20:06

feedback calmed my nerves

@fatso83 fatso83 merged commit 6199e9e into sinonjs:main May 5, 2026
11 checks passed
@fatso83
Copy link
Copy Markdown
Contributor

fatso83 commented May 5, 2026

Thank you!

@fatso83
Copy link
Copy Markdown
Contributor

fatso83 commented May 5, 2026

@till Could you guide me on what to do with this dependency update PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants