improve workflows#2686
Merged
fatso83 merged 2 commits intosinonjs:mainfrom May 5, 2026
Merged
Conversation
- pin all actions to precise commits - avoid credential leakage from actions/checkout - group action updates going forward - add zimor config to ignore "secrets outside env" - add job to keep validating workflows
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
fatso83
previously requested changes
Apr 9, 2026
Contributor
fatso83
left a comment
There was a problem hiding this comment.
Hi, commit specific commits seem a bit scary, TBH. I could live with specific versions, but maybe leave it at a specific tagged version?
Contributor
|
Thank you! |
Contributor
|
@till Could you guide me on what to do with this dependency update PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose (TL;DR) - mandatory
This PR adds a couple improvements for the current workflows:
fetch-depth(on the wrong action)zizmor
zizmor is a neat tool enforce best practices for workflows, if there were any findings, it would creating security annotations via "github advanced security" (which is what the comment is about).
How to verify - mandatory
Approve the workflows, they should continue to run.
Checklist for author
npm run lintpassesReferences to standard library functions are cached.