Revert change removing the ability to use the Philosophers Stone's alt Function#2358
Open
Anoyomouse wants to merge 2 commits intosinkillerj:mc1.20.xfrom
Open
Revert change removing the ability to use the Philosophers Stone's alt Function#2358Anoyomouse wants to merge 2 commits intosinkillerj:mc1.20.xfrom
Anoyomouse wants to merge 2 commits intosinkillerj:mc1.20.xfrom
Conversation
Collaborator
|
Unsure about how sin does version numbers so if you want to revert the version bump I will merge this (though I am unsure if/when we will do another 1.20.1 release). In the meantime I have cherrypicked your commit to the WIP 1.21 branch aed536b |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The philosopher stone's alt function is currently broken (you cannot hold down shift to change stone into grass for example)
By reverting this single change (from #2300) (made in Dec 2023), the alt function starts working again
Not sure if this breaks craft tweaker, but it definitely fixes the issue