Repository navigation
Conversation
Every lock_screen() call spawned another singularity-lockscreen, so an idle lock and an org.freedesktop.ScreenSaver.Lock request arriving together ran two lock clients at once. Keep the spawned client and ignore further requests while it runs, and expose that state as the read-only locked property. Assisted-by: Claude Code:claude-opus-5-5 AI-Scope: tracked the spawned lockscreen subprocess in SessionManager.lock_screen() and added a power_test case for repeated lock requests. (cherry picked from commit 1b0266c)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every lock_screen() call spawned another singularity-lockscreen, so an idle lock and a ScreenSaver.Lock arriving together started two lock clients. Keep the spawned client and ignore further requests while it runs. The state is exposed as a read-only
lockedproperty.New test /power/lock-screen-single-instance: two calls start one client, a call after it exits starts another. On Debian forky (with #16 and #17 applied so main builds): 48 of 49 pass; spell-integration aborts the same way on main in the container.
@mirkobrombin for review when you have a moment.
AI assistance: disclosed