Release/11.14.0#304
Merged
Merged
Conversation
…gle is clicked When a dropdown was rendered inside another dropdown (e.g. facet-list's split-button menu inside facet-filters), clicking the nested toggle closed the ancestor instead of opening the nested menu. The cause was BsDropdownDirective.toggle() calling raiseClear() with no source, so every subscriber — including ancestors — ran clear() and collapsed. raiseClear now propagates the triggering dropdown element, and each directive skips the clear when the source is one of its descendants. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
…havior Adds a Karma spec for BsDropdownDirective with a host that nests one dropdown inside another. The spec asserts the ancestor stays open when the nested toggle is clicked, and verifies the unchanged behavior for outside clicks and non-nested dropdown-item clicks. The spec uncovered a second leak path: when a click synthetically dispatched on the nested .dropdown reaches the document (i.e. when the ancestor menu does not stopPropagation on click, unlike facet-filters), clearMenus emits a clear event whose source is unknown. clear() now also bails out when event.target lives inside a nested .dropdown that is a descendant of this dropdown. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
… toggle is clicked ES-31345 #done fix(dropdown): keep ancestor dropdown open when nested toggle is clicked
- Host components default to standalone:true in Angular 20 - Mark them standalone:false to keep using TestBed declarations
… facet actions menu Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…witching facets, date filter not usable ES-31345 #done fix(facet-filters): dropdown closes immediately when switching facets, date filter not usable
Silence Dart Sass deprecation warnings emitted for facet-list and facet-multi styles by switching to the @use rule. Variables from facet-base remain accessible without namespace via `as *`. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
sync: release/11.13.0 (sba-internal → sba-angular)
Release/11.13.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.