Skip to content

chore: update webhooks tests #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matsk-sinch merged 1 commit into from
Mar 25, 2026
Merged

chore: update webhooks tests #136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...ents/test_numbers_webhooks_event_model.py → ...s/events/test_number_sinch_event_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ def invalid_data():
}


def test_numbers_webhooks_response_expects_parsed_data(valid_data):
def test_number_sinch_event_response_expects_parsed_data(valid_data):
"""
Expects all fields to map correctly from camelCase input
and handle valid data appropriately.
Expand All @@ -51,7 +51,7 @@ def test_numbers_webhooks_response_expects_parsed_data(valid_data):
assert response.extra_field == "extra_value"


def test_numbers_webhooks_response_missing_optional_fields_expects_parsed_data():
def test_number_sinch_event_response_missing_optional_fields_expects_parsed_data():
"""
Expects the model to handle missing optional fields.
"""
Expand All @@ -71,7 +71,7 @@ def test_numbers_webhooks_response_missing_optional_fields_expects_parsed_data()
assert response.failure_code is None


def test_numbers_webhooks_response_invalid_data_expects_validation_error(invalid_data):
def test_number_sinch_event_response_invalid_data_expects_validation_error(invalid_data):
"""
Expects the model to raise a validation error for invalid data.
"""
Expand Down
14 changes: 7 additions & 7 deletions ...bers/v1/webhooks/test_numbers_webhooks.py → ...1/sinch_events/test_number_sinch_event.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ def string_to_sign():


@pytest.fixture
def numbers_webhooks():
def sinch_events():
return SinchEvents('my-callback-secret')


Expand All @@ -34,11 +34,11 @@ def base_payload_parse_event():
}


def test_valid_signature_header_expects_successful_validation(numbers_webhooks, string_to_sign):
def test_valid_signature_header_expects_successful_validation(sinch_events, string_to_sign):
headers = {
"X-Sinch-Signature": "8e58baa351ffa5e0d7eaef3c739d0d7aa6093da3"
}
response = numbers_webhooks.validate_authentication_header(headers, string_to_sign)
response = sinch_events.validate_authentication_header(headers, string_to_sign)
assert response is True


Expand All @@ -56,17 +56,17 @@ def test_valid_signature_header_expects_successful_validation(numbers_webhooks,
)
]
)
def test_parse_event_expects_timestamp_as_utc(numbers_webhooks, test_name, timestamp_str):
def test_parse_event_expects_timestamp_as_utc(sinch_events, test_name, timestamp_str):
payload = {"timestamp": timestamp_str}
parsed = numbers_webhooks.parse_event(payload)
parsed = sinch_events.parse_event(payload)
expected = datetime(
2025, 4, 6, 8, 45, 27, 565347, tzinfo=timezone.utc
)
assert parsed.timestamp == expected


def test_parse_event_expects_parsed_response(numbers_webhooks, base_payload_parse_event):
response = numbers_webhooks.parse_event(base_payload_parse_event)
def test_parse_event_expects_parsed_response(sinch_events, base_payload_parse_event):
response = sinch_events.parse_event(base_payload_parse_event)
assert isinstance(response, NumberSinchEvent)
assert response.event_id == "01jr7stexp0znky34pj07dwp41"
assert response.project_id == "project-id"
Expand Down
Loading