Skip to content

[ENHANCEMENT] Test indexing recovery through its grace deadline #49

Open

Description

@simurg79

Type

Enhancement — low-priority maintenance follow-up

Problem / Value

Indexing keeps an extra list of uncertain files that is read only by tests. Checking the recovery waiting deadline instead would keep tests focused on behavior used by the running extension and avoid unnecessary tracking.

Context

Deferred finding 🟢N1 from round 2 of PR #34: #34, which fixes #23.
Reviewed commit: a21bd59.
Review task: 01a198b0-fe2a-7630-85d8-8e73e7e4c974.

The reviewer suggested either giving the extra tracking a real production use or replacing the test assertions with checks of the grace deadline. This is cleanup, not a reported user-facing failure.

Acceptance criteria

  • Prefer checking recovery deadlines and reconciliation behavior in the tests, then remove the extra list and its test-only accessor if no production use remains.
  • Alternatively, retain the tracking only for a concrete production requirement; do not invent a caller merely to keep it.
  • Preserve coverage for rejected writes, abandoned writes, successful writes after cancellation, and recovery timing.
  • Keep indexing behavior unchanged and run the relevant existing tests when implementing the cleanup.

Constraints/Preferences

Keep this separate from the accepted defensive guard in round-2 finding N2 and the permitted packaged test fixture in round-2 finding 9. Existing issue #39 covers different round-1 cleanup findings and is not changed by this follow-up.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions