Skip to content

[BUG] Preserve parser failure state when retry setup fails #42

Open

Description

@simurg79

Type

Bug

Problem / Value

An explicit indexing retry clears the remembered parser failure before replacement services are ready. If rebuilding those services fails, later automatic initialization no longer sees the original parser-failure guard.

Context

Deferred re-review finding 🟢12 from PR #34: #34, which addresses #23. Source reviewed: 8c38f1c.

The failure flag is cleared before the asynchronous recreation step is awaited. Impact is limited because a separate services-stopped flag remains set; this issue does not claim that automatic indexing definitely restarts today.

Reproduction

Proposed regression test: cause a parser failure, explicitly retry, make service recreation reject, then exercise subsequent automatic initialization and another explicit retry. This failure injection was not run during filing.

Acceptance criteria

  • Keep or restore the parser-failure guard if service recreation fails.
  • Clear it only as part of a successful, explicit recovery.
  • Keep failure status and retry guidance accurate after failed setup.
  • Test failed recreation, successful retry, and automatic initialization after failure.

Constraints/Preferences

Preserve the separate services-stopped protection. Do not combine this follow-up with the already-fixed retry double-rebuild finding 2.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions