Repository navigation
[Priest] Baseline implementation for Forever - #33
Conversation
| { | ||
| priest_spell_t::execute(); | ||
|
|
||
| player->resource_gain( RESOURCE_MANA, player->cache.spirit(), gain, this ); |
There was a problem hiding this comment.
This seems like it gains the spirit in 1 tick, and not spread across the 5 ticks every 3 sec
There was a problem hiding this comment.
True, I've changed it to spread the spirit around the ticks. Something I didn't know and have to check is whether the spirit is a snapshot on cast or if it updates dynamically every tick. I implemented it as a snapshot, but if it is dynamic, it is an easy fix.
There was a problem hiding this comment.
It should be snapshot as it will divide the full value on cast across the ticks so I think it's indeed fine to assume that for now. (assumption based on other Classic-esque talents/wordings)
|
Might be worth to add Vampiric Embrace as Shadow will also cast this, since the heal can proc things like the Revelation enchant Unsure how SimC exactly reads talent ranks, but to me it seems like it always use the max rank of a talent (?) |
Added implementations for VE, HoE, and ToW. Healing things are still TODO, mostly looking to get a baseline out first. For spell ranks, it always picks the highest rank a given actor can use based on level. Each spell declares the levels with spell_container_t. Implementation is at player:L10866, player_t::find_rank |
I mostly meant Talent ranks |
Oh, for talent ranks, it picks up whatever is parsed by the core when the profile is set. It all works automagically. |
Implements most baseline priest spells and talents for Forever:
It also touches on a few core things: