Skip to content

SWCR007-06 PY28 Measure Update#67

Open
unbiya wants to merge 29 commits into
SWCR007-06from
dev-SWCR007-06_PY28
Open

SWCR007-06 PY28 Measure Update#67
unbiya wants to merge 29 commits into
SWCR007-06from
dev-SWCR007-06_PY28

Conversation

@unbiya
Copy link
Copy Markdown
Collaborator

@unbiya unbiya commented May 14, 2026

SWCR007-06 measure update includes:

  • Create new measure folder "commercial measures/SWCR007-06"
  • Update to CZ2025 weather files

Main Contributor: Jenna Moon jmoon@solaris-technical.com

DEER Support Email: DeerSupport@guidehouse.com

PR Author

  • Make sure the PR branch is up to date with main branch at the time of the PR submission
  • Craft a succinct title that effectively encapsulates the essence of the pull request, providing a general overview of the proposed changes.
  • Label the PR with at least one of the following: New Measure, Bug, or Feature.
  • Provide a concise description of the measure, bug, or feature. Submit one PR per measure.
  • For a new measure, attach a workbook named DEER_EnergyPlus_Modelkit_Measure_list_working.xlsx, containing only rows used for post-processing the measure.
  • Add comments in the code when necessary to facilitate the review process.
  • Add a comment before the added code, including the author's full name, company, and specifying if it's a bug fix, new measure, or feature.
  • For a new feature or bug, demonstrate the impact on energy consumption for selected cases with justification using plots and descriptions.
  • For a new measure, add a summary table showing total energy consumption per simulated case.

PR Reviewer

  • Conduct a thorough code review.
  • If the branch is behind the main, merge the branch locally to check for potential conflicts.
  • If a bug, locally reproduce it and compare energy consumptions before and after.
  • Explore creative ways to stress-test the code.
  • Locally check the error file and other outputs.

behzadsalimian and others added 27 commits November 8, 2024 13:27
SWCR007 Lower bound and revised base case
…W/K, LT≈7,522 W/K); remove 1x–10x study rows
Apply SWCR007-05 reviewer recommendations and QC

- Clarified units in parameter declaration for cond_min_temp
- Clarified units in parameter declaration for cond_sct_delta
- Provide alternate baseline variations of minimum condensing temperature setpoint
- Calculate condenser heat rejection capacity with 30 °F condenser approach
- Apply condenser HR capacity in model
@unbiya unbiya mentioned this pull request May 14, 2026
@unbiya unbiya requested a review from behzadsalimian May 14, 2026 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants