Repository navigation
fix(search): read Search MCP date filters without an offset as UTC - #9798
Merged
Merged
Conversation
A date filter sent without its UTC offset failed validation, and the client resent the same value with Z appended, costing a full extra round. Accept the offset-less form and read it as UTC up front. tools/list is unchanged.
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
[Medium impact] The PR appears safe to merge. SummarySearch MCP date filters now treat datetimes without an offset as UTC.
No actionable issues found. Tests were inspected, not run. Reviews (1) · Last reviewed commit: "fix(search): read Search MCP date filter..." · Reviewed by Greptile |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
startDate,endDate,modifiedAfter,modifiedBefore) now accept an ISO datetime without a UTC offset and read it as UTC, instead of failing validationZappended, so the result is the same and the call no longer spends a full extra round on the retryformat: "date-time", same descriptions, no regex), so this adds no tokens to any requestType of Change
Testing
server.protocol.test.ts: an offset-lessstartDate/endDatereaches the use case as UTC, an offset value passes through, and a bare date is still rejected. Fails on staging, passes with the fixlib/knowledge/mcp/suite: 50/50 passingChecklist
test-auditauthoring gate)