Skip to content

improvement(search): send repeated account notes and fixed fields once in Search MCP results - #9796

Merged
waleedlatif1 merged 2 commits into
stagingfrom
improvement/search-mcp-dedupe-output
Nov 8, 2026
Merged

waleedlatif1 merged 2 commits into
stagingfrom
improvement/search-mcp-dedupe-output

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Search MCP search states each repeated account status sentence once in live.notes and flags the accounts it applies to (moreBelow, dateOrderPartial, notSearchedByDeadline, notSearchedOverLimit), instead of repeating the sentence on every account
  • Drops the always-empty retrieval.timedOutLegs, an empty accountId, a displayName equal to the provider, and backend from MCP search results
  • Removes the regex pattern that tools/list carried beside format: "date-time" on each date filter (~370 chars each); parsing still rejects non-ISO dates
  • The splitter sits next to joinMessages so the join and split share one separator; the status sentences are shared constants, so wording can't drift
  • Sim Assistant output is unchanged (projection lives in the MCP adapter)

Benchmark

Paired A/B on an 83-case search eval through the MCP (Sonnet client, 2 attempts per case, two pooled same-commit controls; A/A spread within noise):

  • Input tokens per question: 60k → 51k (−15%, 95% CI −2k to −18k)
  • tools/list: 14.0k → 11.4k chars
  • Correct answers 76.2% → 79.5% (+3.3pp, CI −0.6 to +7.2), source recall +3.3pp (CI +0.5 to +7.0); no right-to-wrong flips, tool errors unchanged

Type of Change

  • Improvement

Testing

  • lib/knowledge/mcp and lib/sim-search/live/pages suites pass (52 tests), including a projection test over every flag and a protocol test asserting tools/list carries format without pattern
  • biome

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Nov 8, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Nov 8, 2026 5:27am UTC

Request Review

@greptile-apps

greptile-apps Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no new actionable issues were found.

Summary

The PR reduces repeated text in Search MCP responses and date-filter schemas.

  • Search MCP results state shared account warnings once and link them to each account.
  • Search and chat list shorter date filters without changing which dates they accept.

Reviews (3) · Last reviewed commit: "test(search): check MCP account notes ag..." · Reviewed by Greptile

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 6 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 6 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit bc8b55f into staging Nov 8, 2026
80 checks passed
@waleedlatif1
waleedlatif1 deleted the improvement/search-mcp-dedupe-output branch November 8, 2026 08:32

This branch was previously deployed

1 inactive deployment
Preview — 37936e1f Deployed Nov 8, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant