Repository navigation
improvement(search): send repeated account notes and fixed fields once in Search MCP results - #9796
Merged
Merged
Conversation
…e in Search MCP results
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
[Medium impact] The PR appears safe to merge; no new actionable issues were found. SummaryThe PR reduces repeated text in Search MCP responses and date-filter schemas.
Reviews (3) · Last reviewed commit: "test(search): check MCP account notes ag..." · Reviewed by Greptile |
Collaborator
Author
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
searchstates each repeated account status sentence once inlive.notesand flags the accounts it applies to (moreBelow,dateOrderPartial,notSearchedByDeadline,notSearchedOverLimit), instead of repeating the sentence on every accountretrieval.timedOutLegs, an emptyaccountId, adisplayNameequal to the provider, andbackendfrom MCP search resultspatternthat tools/list carried besideformat: "date-time"on each date filter (~370 chars each); parsing still rejects non-ISO datesjoinMessagesso the join and split share one separator; the status sentences are shared constants, so wording can't driftBenchmark
Paired A/B on an 83-case search eval through the MCP (Sonnet client, 2 attempts per case, two pooled same-commit controls; A/A spread within noise):
Type of Change
Testing
lib/knowledge/mcpandlib/sim-search/live/pagessuites pass (52 tests), including a projection test over every flag and a protocol test asserting tools/list carriesformatwithoutpatternChecklist
test-auditauthoring gate)