Skip to content

fix(desktop): return account sites from the source-connect e2e server - #9795

Merged
waleedlatif1 merged 1 commit into
stagingfrom
fix/desktop-source-connect-e2e
Nov 8, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
fix/desktop-source-connect-e2e

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • improvement(integrations): show the sites an Atlassian account reaches #9762 made sites a required field on each viewerAccounts entry in the organization-accounts response contract
  • The source-connect desktop e2e fake server still returned accounts without it, so requestJson rejected the response and the web authorization step saw 0 accounts
  • Return sites: [] from the fake server, matching the real response shape

Type of Change

  • Bug fix

Testing

  • Parsed the old and fixed fake payloads against getOrganizationAccountsContract.response.schema: old fails on viewerAccounts[0].sites, fixed passes
  • biome check on the spec, apps/desktop type-check
  • desktop-e2e runs in CI on this PR

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

🤖 Generated with Claude Code

@vercel

vercel Bot commented Nov 8, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Nov 8, 2026 2:31am UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit e6a9dbe into staging Nov 8, 2026
47 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/desktop-source-connect-e2e branch November 8, 2026 02:32
@greptile-apps

greptile-apps Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] This change appears safe to merge.

Summary

Adds sites: [] to the fake server’s connected account so its response matches getOrganizationAccountsContract.

  • The account fixture now returns the empty site list the web flow expects.

Reviews (1) · Last reviewed commit: "fix(desktop): return account sites from ..." · Reviewed by Greptile

This branch was previously deployed

1 inactive deployment
Preview — df3de849 Deployed Nov 8, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant