Repository navigation
fix(oauth): reject cross-site Instagram workspace launches - #9788
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
[Medium impact] The PR appears safe to merge; the new check blocks the targeted launch without changing draft-backed flows. SummaryBlocks cross-site Instagram workspace launches before they create a connection draft.
Reviews (1) · Last reviewed commit: "fix(oauth): reject cross-site Instagram ..." · Reviewed by Greptile |
6 tasks done
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GET /api/auth/instagram/authorize?workspaceId=…creates a connection draft from the query alone, the same pattern fix(oauth): reject cross-site workspace OAuth launches #9772 closed on/api/auth/oauth2/authorize, but this sibling route had no cross-site checkSec-Fetch-Siteiscross-site, using the sameisCrossSiteSessionRequesthelper; thedraftIdpath is unchangeddraftId, so neither changes behaviorType of Change
Testing
instagram/authorizeandoauth2/authorizeroute tests (48 passing),test:scripts, biomecheck:test-typesbaseline entry is removedChecklist
test-auditauthoring gate)🤖 Generated with Claude Code