Repository navigation
fix(video): read the active start frame input when serializing video settings - #9787
Merged
Merged
Conversation
…settings Sub-block conditions in the serializer and on the canvas card did not get the block's canonical mode overrides, so the Video Generator guessed the active start frame input from which member held a value. A frame left in the inactive input hid prompt-only settings (fal aspect ratio, Runway ratio) and dropped them from the request. A shared withCanonicalModes helper now feeds the same condition values to the serializer, canvas card, editor layout, autolayout and dropdown options.
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
[Medium impact] The PR appears safe to merge; no actionable issues were found. SummaryPasses the block’s saved basic/advanced choices to video field conditions so an inactive start frame no longer hides settings.
|
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
__canonicalModes) to sub-block conditions, like the editor and autolayout already didwithCanonicalModeshelper inlib/workflows/subblocks/visibility.tsreplaces the inline copies in the editor layout hook, autolayout and dropdown options__canonicalModes, and the key never reaches serialized paramsType of Change
Testing
field-analysis.test.tscases (frame left in the inactive upload / inactive reference input) and a newcanvas-card-fields.test.tscase; all three fail on the pre-fix code and pass nowvideo_generatorsuites (46 files, 379 tests),bun run lint,check-block-registry.ts origin/stagingChecklist
test-auditauthoring gate)