Skip to content

fix(video): read the active start frame input when serializing video settings - #9787

Merged
waleedlatif1 merged 1 commit into
stagingfrom
fix/video-serializer-canonical-modes
Nov 7, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
fix/video-serializer-canonical-modes

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Serializer and canvas card now pass the block's canonical mode overrides (__canonicalModes) to sub-block conditions, like the editor and autolayout already did
  • Fixes Video Generator settings being dropped when a start frame sits in the inactive reference input: conditions guessed the active member from which one held a value, hid prompt-only settings (fal aspect ratio, Runway ratio), and the request fell back to the model default
  • New shared withCanonicalModes helper in lib/workflows/subblocks/visibility.ts replaces the inline copies in the editor layout hook, autolayout and dropdown options
  • Only the Video Generator reads __canonicalModes, and the key never reaches serialized params

Type of Change

  • Bug fix

Testing

  • New field-analysis.test.ts cases (frame left in the inactive upload / inactive reference input) and a new canvas-card-fields.test.ts case; all three fail on the pre-fix code and pass now
  • Ran serializer, subblock, workflow blocks, autolayout, editor and video_generator suites (46 files, 379 tests), bun run lint, check-block-registry.ts origin/staging

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

…settings

Sub-block conditions in the serializer and on the canvas card did not get the
block's canonical mode overrides, so the Video Generator guessed the active
start frame input from which member held a value. A frame left in the inactive
input hid prompt-only settings (fal aspect ratio, Runway ratio) and dropped
them from the request. A shared withCanonicalModes helper now feeds the same
condition values to the serializer, canvas card, editor layout, autolayout and
dropdown options.
@vercel

vercel Bot commented Nov 7, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Nov 7, 2026 9:32pm UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 8 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no actionable issues were found.

Summary

Passes the block’s saved basic/advanced choices to video field conditions so an inactive start frame no longer hides settings.

  • The Video Generator uses the selected start-frame input for its settings.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  Values[Block values] --> Helper[withCanonicalModes]
  Modes[Saved mode choices] --> Helper
  Helper --> Conditions[Video field conditions]
  Conditions --> Card[Visible card fields]
  Conditions --> Serializer[Fields kept by serializer]
  Serializer --> Params[Runtime params without added metadata]
Loading

Reviews (1) · Last reviewed commit: "fix(video): read the active start frame ..." · Reviewed by Greptile

@waleedlatif1
waleedlatif1 merged commit 887bece into staging Nov 7, 2026
62 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/video-serializer-canonical-modes branch November 7, 2026 21:35

This branch was previously deployed

1 inactive deployment
Preview — a78dfc28 Deployed Nov 7, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant