Repository navigation
fix(desktop): explain macOS Local Network blocks for private self-hosted servers - #9777
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
[Medium impact] The PR appears safe to merge; no actionable issues were found. SummaryExplains macOS Local Network blocks when Sim Desktop cannot reach a self-hosted server.
The latest revision adds the macOS version check. No new actionable issues were found. No previous review threads were supplied. Reviews (2) · Last reviewed commit: "fix(desktop): only show Local Network gu..." · Reviewed by Greptile |
There was a problem hiding this comment.
All reported issues were addressed across 4 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
Summary
ERR_ADDRESS_UNREACHABLE (-109). That's macOS Local Network privacy failing the socket withEHOSTUNREACH, not Chromium. Chromium's Local Network Access blocks report-36/-384/-385, never-109.NSLocalNetworkUsageDescriptionto the mac bundle so the system prompt says why Sim needs local network access-109on macOS as a newlocal_networkload failure, and have the offline page tell the user to turn on Sim under System Settings > Privacy & Security > Local Network. Other platforms keep the generic unreachable copy.--ip-address-space-overridesentries only asip:portor CIDR and silently drops hostnames, so that override never appliedType of Change
Testing
load-health.test.ts: new-109darwin/linux/win32 case, red against the pre-fixclassifyLoadError, green with the fixbun run --cwd apps/desktop test(93 files, 1282 tests), desktoptype-check,bun run lintip_address_space_util.ccandnet_error_list.h, and confirmed with an Electron 43.8.1 script that the override switch only reaches the network service when it's appended synchronously at startupChecklist
test-auditauthoring gate)🤖 Generated with Claude Code