Skip to content

fix(desktop): explain macOS Local Network blocks for private self-hosted servers - #9777

Merged
waleedlatif1 merged 2 commits into
stagingfrom
fix/desktop-macos-local-network
Nov 7, 2026
Merged

waleedlatif1 merged 2 commits into
stagingfrom
fix/desktop-macos-local-network

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Sim Desktop on macOS 15+ couldn't load a self-hosted server on a private address: ERR_ADDRESS_UNREACHABLE (-109). That's macOS Local Network privacy failing the socket with EHOSTUNREACH, not Chromium. Chromium's Local Network Access blocks report -36/-384/-385, never -109.
  • Add NSLocalNetworkUsageDescription to the mac bundle so the system prompt says why Sim needs local network access
  • Classify -109 on macOS as a new local_network load failure, and have the offline page tell the user to turn on Sim under System Settings > Privacy & Security > Local Network. Other platforms keep the generic unreachable copy.
  • Supersedes fix(desktop): allow private self-hosted origins #9765: Chromium 150 (Electron 43) parses --ip-address-space-overrides entries only as ip:port or CIDR and silently drops hostnames, so that override never applied

Type of Change

  • Bug fix

Testing

  • load-health.test.ts: new -109 darwin/linux/win32 case, red against the pre-fix classifyLoadError, green with the fix
  • bun run --cwd apps/desktop test (93 files, 1282 tests), desktop type-check, bun run lint
  • Checked Chromium 150.0.7871.250's ip_address_space_util.cc and net_error_list.h, and confirmed with an Electron 43.8.1 script that the override switch only reaches the network service when it's appended synchronously at startup

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

🤖 Generated with Claude Code

@vercel

vercel Bot commented Nov 7, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Nov 7, 2026 8:31pm UTC

Request Review

@greptile-apps

greptile-apps Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no actionable issues were found.

Summary

Explains macOS Local Network blocks when Sim Desktop cannot reach a self-hosted server.

  • The desktop explains when macOS blocks a private Sim server.

The latest revision adds the macOS version check. No new actionable issues were found. No previous review threads were supplied.

Reviews (2) · Last reviewed commit: "fix(desktop): only show Local Network gu..." · Reviewed by Greptile

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 4 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

Comment thread apps/desktop/src/main/load-health.ts Resolved
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit d5451f6 into staging Nov 7, 2026
48 of 49 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/desktop-macos-local-network branch November 7, 2026 20:34

This branch was previously deployed

1 inactive deployment
Preview — e362e1df Deployed Nov 7, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant