fix(knowledge): stabilize skipped connector documents

[waleedlatif1]

Summary

• reuse the same replacement rule for listing-time and hydration-time skipped documents
• persist a rediscovered skip when the existing row is already a content-less failed placeholder
• keep last-known-good indexed content unless a connector explicitly declares the skip authoritative
• preserve every existing retry path, including same-hash placeholder hydration

Production evidence

A production GitHub sync reported previously recorded binary placeholders as source failures after the ingestion hardening rollout. Trigger traces showed successful listing and processing dispatch, while persisted state showed the reported failures were existing binary placeholders rather than GitHub API or child-processing failures. The hydration path rediscovered an intentional binary skip but, unlike the equivalent listing-time path, treated the content-less existing row as an unverified indexed refresh.

Why this is minimal

The correction extracts the existing skip-replacement predicate and reuses it after deferred hydration. Existing content-less placeholders continue to rehydrate so providers with weak or absent modification metadata can recover. A rediscovered intentional skip is persisted and counted as docsSkipped; indexed last-known-good content is still retained unless the connector opts into authoritative replacement. No provider-specific suppression, retry change, or alert filtering is added.

Validation

• 45 connector/sync test files, 1,416 tests passed
• monorepo lint passed (one unrelated pre-existing unused suppression warning)
• monorepo type-check passed (26 tasks)
• all 33 repository audits passed
• block registry audit passed
• agent-stream docs and skills generators were idempotent

No schema or migration changes.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
docs	Skipped		Aug 26, 2026 9:46pm

[greptile-apps]

Greptile Summary

The PR aligns deferred-hydration skip handling with listing-time reconciliation while preserving retry behavior for content-less placeholders.

• Extracts a shared predicate for deciding whether a skipped document replaces an existing record.
• Applies that predicate after deferred hydration.
• Adds focused coverage for placeholder, indexed-content, and authoritative-replacement cases.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains; the previously reported retry path remains reachable because unchanged content-less placeholders still enter hydration during normal syncs.

Important Files Changed

Filename	Overview
apps/sim/lib/knowledge/connectors/sync-engine.ts	Extracts and reuses the skip-replacement predicate during deferred hydration without disabling same-hash placeholder rehydration.
apps/sim/lib/knowledge/connectors/sync-engine.test.ts	Adds focused assertions covering content-less placeholders, indexed content retention, and authoritative skip replacement.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Listed external document] --> B{Needs deferred hydration?}
  B -- No --> C[Apply skip replacement predicate]
  B -- Yes --> D[Hydrate document]
  D --> E{Hydration returns skip?}
  E -- No --> F[Continue normal processing]
  E -- Yes --> C
  C --> G{Existing row has no storage key or skip is authoritative?}
  G -- Yes --> H[Persist and count intentional skip]
  G -- No --> I[Retain last-known-good indexed content]

Loading

_{Reviews (2): Last reviewed commit: "fix(knowledge): stabilize skipped connec..." | Re-trigger Greptile}

[waleedlatif1]

@greptile

[waleedlatif1]

@cubic

[cubic-dev-ai]

@cubic

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

[cubic-dev-ai]

No issues found across 2 files

Confidence score: 5/5

• Automated review surfaced no issues in the provided summaries.
• No files require special attention.

_{Re-trigger cubic}