Skip to content

fix(fireflies): handle nullable transcript metadata - #7129

Merged
waleedlatif1 merged 1 commit into
stagingfrom
codex/fireflies-malformed-metadata
Aug 26, 2026
Merged

fix(fireflies): handle nullable transcript metadata#7129
waleedlatif1 merged 1 commit into
stagingfrom
codex/fireflies-malformed-metadata

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • validate Fireflies transcript responses against the provider's documented nullable GraphQL shape
  • normalize nullable metadata and nested entries without weakening document identity checks
  • add regression coverage for nullable, omitted, and malformed transcript fields

Type of Change

  • Bug fix

Testing

  • 55 Fireflies connector tests
  • 1,404 connector tests
  • monorepo lint and type-check
  • 33 repository audits

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Aug 26, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Skipped Skipped Aug 26, 2026 9:28pm

Request Review

@greptile-apps

greptile-apps Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR updates the Fireflies connector to accept documented nullable or omitted transcript metadata while continuing to require a stable, nonempty transcript ID.

  • Replaces the narrow transcript guard with detailed Zod validation for list and hydration responses.
  • Normalizes nullable participant, speaker, host, date, and transcript fields before producing connector documents.
  • Adds regression tests for nullable, omitted, and malformed metadata.

Confidence Score: 5/5

The PR appears safe to merge because no concrete blocking or independently actionable non-blocking issue remains.

The connector preserves nonempty transcript identity validation, safely normalizes nullable provider metadata, and retains explicit rejection of malformed non-null response shapes.

Important Files Changed

Filename Overview
apps/sim/connectors/fireflies/fireflies.ts Adds nullable-aware provider response validation and normalization without weakening document identity checks; no actionable regression was established.
apps/sim/connectors/fireflies/fireflies.test.ts Adds focused coverage for nullable, omitted, malformed, and nested transcript metadata.

Reviews (1): Last reviewed commit: "fix(fireflies): handle nullable transcri..." | Re-trigger Greptile

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit adbb9b6 into staging Aug 26, 2026
30 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/fireflies-malformed-metadata branch August 26, 2026 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant