fix(landing): stabilize platform preview motion - #7108
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
Greptile SummaryThe PR replaces ResizeObserver-driven CSS scaling with fixed SVG viewBox coordinate systems for shared landing-page previews and workflow stages.
Confidence Score: 5/5The PR appears safe to merge, with no concrete blocking or independently actionable non-blocking defects identified. The new viewBox geometry matches the existing preview aspect ratio, workflow blocks and connectors use shared dimensions, and all reset-duration imports were consistently migrated to the new constants module.
|
| Filename | Overview |
|---|---|
| apps/sim/app/(landing)/components/shared/hero-loop-shell/hero-loop-shell.tsx | Replaces responsive CSS-transform scaling with a fixed 1280x735 SVG viewBox containing the sidebar and workspace. |
| apps/sim/app/(landing)/components/hero/components/hero-platform-loop/hero-workflow-stage.tsx | Moves workflow edges and block cards into one stable SVG coordinate system while preserving build and selection transitions. |
| apps/sim/app/(landing)/components/shared/platform-loop-constants.ts | Centralizes the landing-preview design dimensions and animation reset fade duration. |
| apps/sim/app/(landing)/enterprise/components/enterprise-platform-loop/enterprise-sidebar.tsx | Adds paint isolation and transform compositing hints to the shared preview sidebar. |
| apps/sim/app/(landing)/hooks/use-design-scale.ts | Removes the obsolete ResizeObserver-based design-scale hook after all consumers migrate to SVG scaling. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart LR
Frame[Landing preview frame] --> Shell[HeroLoopShell SVG viewBox]
Shell --> Sidebar[Enterprise sidebar]
Shell --> Workspace[Animated workspace]
Workspace --> Stage[Workflow-stage SVG viewBox]
Stage --> Edges[Connector paths]
Stage --> Blocks[Block foreignObjects]
Reviews (1): Last reviewed commit: "fix(landing): stabilize platform preview..." | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type of Change
Testing
bun run type-checkbun run lint:checkbun run apps/sim/scripts/check-block-registry.ts cba03579862549a0e70892fa06a392f12c6ff6cabun run check:audits(33/33 passed)Checklist
Screenshots/Videos