Skip to content

Conversation

@emir-karabeg
Copy link
Collaborator

Summary

Changes globals light colors to minimize the green tint

Type of Change

  • New feature

Testing

Solo.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel
Copy link

vercel bot commented Dec 28, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Review Updated (UTC)
docs Skipped Skipped Dec 28, 2025 9:18pm

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Dec 28, 2025

Greptile Summary

Replaced warm greenish color palette in light theme with neutral grays to minimize green tint. Updated 48 CSS variables in globals.css including backgrounds (--bg, --surface-*), borders (--border, --border-*), and terminal status colors. Component files updated to adapt to new color scheme, with many adding explicit dark: variants for consistency.

Notable changes:

  • Changed light theme from warm tones (#f9faf8, #d7dcda) to neutral grays (#fdfdfd, #e0e0e0)
  • Updated surface layers to use lighter backgrounds in light mode (surface-3 instead of surface-4/5)
  • Added bg-white and dark:bg-[var(--bg)] to main content areas across knowledge, templates, and logs pages
  • Fixed layout padding in knowledge, logs, and templates to use dynamic --sidebar-width variable instead of hardcoded pl-60
  • Changed workflow edge handles from --surface-7 to --workflow-edge variable for consistency

Custom instruction concern:
This PR edits globals.css extensively, which violates custom instruction that states "Avoid editing the globals.css file unless absolutely necessary. Move style changes to local component files instead." However, changing the base color palette requires globals.css modifications, so this appears justified.

Confidence Score: 4/5

  • This PR is safe to merge with minimal risk - primarily visual changes to color palette
  • Score reflects that these are well-structured visual changes with proper dark mode variants. The changes are systematic and consistent across files. Main concern is the extensive globals.css modification which technically violates a custom instruction, but is justified for a base color palette change. No logical bugs or breaking changes detected.
  • No files require special attention - all changes follow consistent patterns

Important Files Changed

Filename Overview
apps/sim/app/_styles/globals.css Changed light theme colors from warm greenish tones to neutral grays, violates custom instruction about avoiding globals.css edits
apps/sim/app/workspace/[workspaceId]/knowledge/components/base-card/base-card.tsx Updated card backgrounds from surface-4 to surface-3 with dark mode variants for consistency with new color scheme
apps/sim/app/workspace/[workspaceId]/templates/components/template-card.tsx Updated skeleton and card backgrounds from surface-4/5 to surface-3/4 with dark mode fallbacks
apps/sim/app/workspace/[workspaceId]/logs/components/dashboard/dashboard.tsx Updated chart card backgrounds from surface-1 to surface-2 for light mode with dark mode variants
apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/subflows/subflow-node.tsx Changed handle colors from surface-7 to workflow-edge variable, adjusted positioning, added border to start node

Sequence Diagram

sequenceDiagram
    participant Dev as Developer
    participant GC as globals.css
    participant CV as CSS Variables
    participant Comps as Components
    participant UI as User Interface

    Dev->>GC: Update light theme colors
    GC->>CV: Define new neutral palette
    Note over CV: --bg: #fdfdfd<br/>--surface-1 to -7<br/>--border: #e0e0e0<br/>--workflow-edge
    
    Dev->>Comps: Update component backgrounds
    Comps->>Comps: Change surface-4/5 → surface-3/4
    Comps->>Comps: Add dark: variants
    Comps->>Comps: Add bg-white for light mode
    
    Dev->>Comps: Fix layout padding
    Comps->>Comps: pl-60 → pl-[var(--sidebar-width)]
    
    Dev->>Comps: Update workflow handles
    Comps->>Comps: --surface-7 → --workflow-edge
    
    Comps->>CV: Reference updated variables
    CV->>UI: Render neutral color scheme
    UI->>UI: Display without green tint
Loading

@emir-karabeg
Copy link
Collaborator Author

@greptile

@emir-karabeg emir-karabeg merged commit 1c626df into staging Dec 28, 2025
11 checks passed
@emir-karabeg emir-karabeg deleted the improvement/ui branch December 28, 2025 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants