Repository navigation
improvement(resume): resolve a pause point's block from its loop-scoped context id - #10119
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
[Medium impact] The PR appears safe to merge; no actionable issues were found. Summary
No actionable issues found. Tests were inspected but not run. Reviews (1) · Last reviewed commit: "improvement(resume): resolve a pause poi..." · Reviewed by Greptile |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pauseBaseBlockIdnow strips the loop digest itself, so a pause point keyed only by its context id (block₍N₎_loopK) resolves to its workflow block without relying onmapPausePointshaving normalized it firststripLoopDigestto the subflow node id codec and replaced the manager's inline/_loop\d+/gcopy with it (same pattern, same behavior)stripCloneSuffixesdeliberately keeps_loopN: executor block-output resolution instate.tscompares against it before its own loop-suffix filterType of Change
Testing
pause-block-names.test.tscovers loop, parallel-in-loop, and cloned-branch-in-loop context ids; all three fail with the oldpauseBaseBlockIdand pass with the fixsubflow-node-id-codec,execution-status,execution-status-projection,human-in-the-loop-manager, and executorstatetests pass (150 tests)bun run lint; type-check and audits in CIChecklist
test-auditauthoring gate)