Skip to content

improvement(resume): resolve a pause point's block from its loop-scoped context id - #10119

Merged
waleedlatif1 merged 1 commit into
stagingfrom
improvement/pause-block-id-loop-digest
Nov 17, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
improvement/pause-block-id-loop-digest

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • pauseBaseBlockId now strips the loop digest itself, so a pause point keyed only by its context id (block₍N₎_loopK) resolves to its workflow block without relying on mapPausePoints having normalized it first
  • Added stripLoopDigest to the subflow node id codec and replaced the manager's inline /_loop\d+/g copy with it (same pattern, same behavior)
  • stripCloneSuffixes deliberately keeps _loopN: executor block-output resolution in state.ts compares against it before its own loop-suffix filter

Type of Change

  • Improvement

Testing

  • New pause-block-names.test.ts covers loop, parallel-in-loop, and cloned-branch-in-loop context ids; all three fail with the old pauseBaseBlockId and pass with the fix
  • subflow-node-id-codec, execution-status, execution-status-projection, human-in-the-loop-manager, and executor state tests pass (150 tests)
  • bun run lint; type-check and audits in CI

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Nov 17, 2026 5:47am UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no actionable issues were found.

Summary

pauseBaseBlockId now removes loop suffixes before removing branch and clone suffixes.

  • Pause-point context IDs resolve to their workflow block inside loops.

No actionable issues found. Tests were inspected but not run.

Reviews (1) · Last reviewed commit: "improvement(resume): resolve a pause poi..." · Reviewed by Greptile

@waleedlatif1
waleedlatif1 merged commit e46bc84 into staging Nov 17, 2026
81 checks passed
@waleedlatif1
waleedlatif1 deleted the improvement/pause-block-id-loop-digest branch November 17, 2026 06:00

This branch was previously deployed

1 inactive deployment
Preview — bd441fd2 Deployed Nov 17, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant