Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions apps/sim/executor/handlers/mothership/handler.ts
Original file line number Diff line number Diff line change
Expand Up @@ -571,8 +571,9 @@ async function readMothershipExecuteResponse(
const { done, value } = await reader.read()
if (done) break

buffer += decoder.decode(value, { stream: true })
const lines = buffer.split('\n')
// `buffer` never holds a newline, so only the new text needs splitting.
const lines = decoder.decode(value, { stream: true }).split('\n')
lines[0] = buffer + lines[0]
buffer = lines.pop() ?? ''
for (const line of lines) {
await processLine(line)
Expand Down Expand Up @@ -700,8 +701,9 @@ function createMothershipStreamingExecution(
if (cancelled) return
if (done) break

buffer += decoder.decode(value, { stream: true })
const lines = buffer.split('\n')
// `buffer` never holds a newline, so only the new text needs splitting.
const lines = decoder.decode(value, { stream: true }).split('\n')
lines[0] = buffer + lines[0]
buffer = lines.pop() ?? ''
for (const line of lines) {
await processLine(line)
Expand Down
6 changes: 4 additions & 2 deletions apps/sim/lib/core/utils/sse.ts
Original file line number Diff line number Diff line change
Expand Up @@ -166,8 +166,10 @@ export async function readSSELines(source: SSESource, options: ReadSSELinesOptio

const { done, value } = await readChunk()

buffer += done ? decoder.decode() : decoder.decode(value, { stream: true })
const lines = buffer.split('\n')
// `buffer` never holds a newline, so split only the new text: re-splitting
// the whole pending line on every chunk is quadratic in the event size.
const lines = (done ? decoder.decode() : decoder.decode(value, { stream: true })).split('\n')
lines[0] = buffer + lines[0]
buffer = done ? '' : (lines.pop() ?? '')

for (const rawLine of lines) {
Expand Down
6 changes: 3 additions & 3 deletions packages/sim-cli/src/commands/protocol/workflow-run-follow.ts
Original file line number Diff line number Diff line change
Expand Up @@ -272,9 +272,9 @@ async function* sseData(body: ReadableStream<Uint8Array>): AsyncGenerator<string
try {
while (true) {
const { done, value } = await reader.read()
buffer += done ? decoder.decode() : decoder.decode(value, { stream: true })

const lines = buffer.split('\n')
// `buffer` never holds a newline, so only the new text needs splitting.
const lines = (done ? decoder.decode() : decoder.decode(value, { stream: true })).split('\n')
lines[0] = buffer + lines[0]
buffer = done ? '' : (lines.pop() ?? '')

for (const rawLine of lines) {
Expand Down
6 changes: 3 additions & 3 deletions packages/sim-cli/src/http/ndjson.ts
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,9 @@ export async function* readNdjson(
try {
while (true) {
const { done, value } = await reader.read()
buffer += done ? decoder.decode() : decoder.decode(value, { stream: true })

const lines = buffer.split('\n')
// `buffer` never holds a newline, so only the new text needs splitting.
const lines = (done ? decoder.decode() : decoder.decode(value, { stream: true })).split('\n')
lines[0] = buffer + lines[0]
buffer = done ? '' : (lines.pop() ?? '')
for (const line of lines) {
const event = parse(line)
Expand Down
Loading