Skip to content

Rework the translation browser, and catch placeholder drift in validate #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
simoncodes-ca merged 16 commits into from
Sep 8, 2026
Merged

Rework the translation browser, and catch placeholder drift in validate #95

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
4b01558
feat(tracker): make the folder tree collapsible and add a collection …
SimonNodel-AI Sep 5, 2026
2cd931c
fix(tracker): resolve header counts through the transloco pipe
SimonNodel-AI Sep 6, 2026
ae2795e
fix(tracker): correct mistranslated status and editor copy
SimonNodel-AI Sep 6, 2026
407d9a0
feat(tracker): rework the translation editor dialog
SimonNodel-AI Sep 6, 2026
cdc2442
fix(tracker): unify the browser content toolbar
SimonNodel-AI Sep 6, 2026
4463497
fix(tracker): make the translation item legible and honest
SimonNodel-AI Sep 7, 2026
0a2aa5d
fix(api): cache collections independently instead of one at a time
SimonNodel-AI Sep 7, 2026
da9da80
fix(tracker): lead the compact row with the source string
SimonNodel-AI Sep 7, 2026
ce167bf
fix(tracker): separate the two issue states the rollup ring merged
SimonNodel-AI Sep 7, 2026
92e8b56
fix(tracker): raise the skip link above the contrast floor
SimonNodel-AI Sep 7, 2026
91985c8
fix(tracker): set the resource comment as prose, not fine print
SimonNodel-AI Sep 8, 2026
f273c5d
feat(tracker): make status a first-class control in the browser toolbar
SimonNodel-AI Sep 8, 2026
72abeec
fix(tracker): restore interpolation in translated aria-labels
SimonNodel-AI Sep 8, 2026
18c824e
feat(cli): validate that translations interpolate the base value's pl…
SimonNodel-AI Sep 8, 2026
134138f
fix(sample-translations): repair escaped placeholders in playground f…
SimonNodel-AI Sep 8, 2026
15db76d
chore: disable auto-translation in the lingo-tracker config
SimonNodel-AI Sep 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions .lingo-tracker.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,8 @@
}
},
"translation": {
"enabled": true,
"provider": "google-translate",
"apiKeyEnv": "GOOGLE_TRANSLATE_API_KEY"
"enabled": false,
"provider": "google-translate"
},
"bundles": {
"main": {
Expand Down
104 changes: 81 additions & 23 deletions apps/api/src/app/cache/collection-cache.service.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,14 +159,15 @@ describe('CollectionCacheService', () => {
expect(service.getCacheStatus('Main')).toBe(CacheStatus.ERROR);
});

it('should clear previous collection cache when setting new collection', () => {
it('should keep an existing collection cached when another collection is added', () => {
const mainTree = createMockTree(['main']);
mockCore.extractResourcesRecursively.mockReturnValue(mainTree.resources);
service.setCacheStatus('Main', CacheStatus.READY, mainTree, undefined, 3);
expect(service.getCacheStatus('Main')).toBe(CacheStatus.READY);

service.setCacheStatus('Admin', CacheStatus.INDEXING);
expect(service.getCacheStatus('Main')).toBe(CacheStatus.NOT_STARTED);
expect(service.getCacheStatus('Main')).toBe(CacheStatus.READY);
expect(service.getCache('Main')).toEqual(mainTree);
expect(service.getCacheStatus('Admin')).toBe(CacheStatus.INDEXING);
});

Expand Down Expand Up @@ -262,24 +263,87 @@ describe('CollectionCacheService', () => {
service.setCacheStatus('Main', CacheStatus.READY, mockTree, undefined, 3);
expect(service.getCacheStatus('Main')).toBe(CacheStatus.READY);

service.clearCache();
service.clearCache('Main');
expect(service.getCacheStatus('Main')).toBe(CacheStatus.NOT_STARTED);
expect(service.getCache('Main')).toBeNull();
});

it('should handle clearing when no collection is cached', () => {
expect(() => service.clearCache()).not.toThrow();
expect(() => service.clearCache('Main')).not.toThrow();
expect(service.getCacheStatus('Main')).toBe(CacheStatus.NOT_STARTED);
});

it('should allow new collection to be cached after clearing', () => {
const mockTree = createMockTree();
mockCore.extractResourcesRecursively.mockReturnValue(mockTree.resources);
service.setCacheStatus('Main', CacheStatus.READY, mockTree, undefined, 3);
service.clearCache();
service.clearCache('Main');
service.setCacheStatus('Admin', CacheStatus.INDEXING);
expect(service.getCacheStatus('Admin')).toBe(CacheStatus.INDEXING);
});

it('should leave other collections untouched', () => {
const mainTree = createMockTree(['main']);
const adminTree = createMockTree(['admin']);
mockCore.extractResourcesRecursively.mockReturnValue(mainTree.resources);
service.setCacheStatus('Main', CacheStatus.READY, mainTree, undefined, 3);
service.setCacheStatus('Admin', CacheStatus.READY, adminTree, undefined, 2);

service.clearCache('Main');

expect(service.getCacheStatus('Main')).toBe(CacheStatus.NOT_STARTED);
expect(service.getCacheStatus('Admin')).toBe(CacheStatus.READY);
expect(service.getCache('Admin')).toEqual(adminTree);
});

it('should drop every collection when all caches are cleared', () => {
const mainTree = createMockTree(['main']);
const adminTree = createMockTree(['admin']);
mockCore.extractResourcesRecursively.mockReturnValue(mainTree.resources);
service.setCacheStatus('Main', CacheStatus.READY, mainTree, undefined, 3);
service.setCacheStatus('Admin', CacheStatus.READY, adminTree, undefined, 2);

service.clearAllCaches();

expect(service.getCacheStatus('Main')).toBe(CacheStatus.NOT_STARTED);
expect(service.getCacheStatus('Admin')).toBe(CacheStatus.NOT_STARTED);
expect(service.getCachedCollectionNames()).toEqual([]);
});
});

describe('cache limit', () => {
it('should evict the least recently used collection once the limit is reached', () => {
process.env.LINGO_TRACKER_MAX_CACHED_COLLECTIONS = '2';
const limitedService = new CollectionCacheService();
delete process.env.LINGO_TRACKER_MAX_CACHED_COLLECTIONS;

const tree = createMockTree();
mockCore.extractResourcesRecursively.mockReturnValue(tree.resources);

limitedService.setCacheStatus('First', CacheStatus.READY, tree, undefined, 1);
limitedService.setCacheStatus('Second', CacheStatus.READY, tree, undefined, 1);

// Touching First makes Second the least recently used entry.
limitedService.getCache('First');

limitedService.setCacheStatus('Third', CacheStatus.READY, tree, undefined, 1);

expect(limitedService.getCacheStatus('Second')).toBe(CacheStatus.NOT_STARTED);
expect(limitedService.getCacheStatus('First')).toBe(CacheStatus.READY);
expect(limitedService.getCacheStatus('Third')).toBe(CacheStatus.READY);
});

it('should never evict a collection that is still indexing', () => {
process.env.LINGO_TRACKER_MAX_CACHED_COLLECTIONS = '1';
const limitedService = new CollectionCacheService();
delete process.env.LINGO_TRACKER_MAX_CACHED_COLLECTIONS;

limitedService.setCacheStatus('First', CacheStatus.INDEXING);
limitedService.setCacheStatus('Second', CacheStatus.INDEXING);

expect(limitedService.getCacheStatus('First')).toBe(CacheStatus.INDEXING);
expect(limitedService.getCacheStatus('Second')).toBe(CacheStatus.INDEXING);
});
});

describe('indexCollection', () => {
Expand Down Expand Up @@ -364,14 +428,14 @@ describe('CollectionCacheService', () => {
expect(service.getCacheStatus('Main')).toBe(CacheStatus.READY);
expect(service.getCache('Main')).toEqual(mainTree);

// Index Admin (this should clear Main's cache)
// Index Admin alongside Main
await service.indexCollection('Admin', 'src/admin/i18n', 2);

expect(service.getCacheStatus('Admin')).toBe(CacheStatus.READY);
expect(service.getCache('Admin')).toEqual(adminTree);

// Main should have been cleared when Admin started
expect(service.getCacheStatus('Main')).toBe(CacheStatus.NOT_STARTED);
// Main is untouched by Admin's indexing
expect(service.getCacheStatus('Main')).toBe(CacheStatus.READY);
});

it('should store error message when indexing fails', async () => {
Expand All @@ -397,7 +461,7 @@ describe('CollectionCacheService', () => {
expect(service.getCacheStatus('Main')).toBe(CacheStatus.ERROR);
});

it('should clear previous collection cache when indexing new collection', async () => {
it('should keep both collections cached when indexing a second one', async () => {
const mainTree = createMockTree(['main']);
const adminTree = createMockTree(['admin']);

Expand All @@ -411,12 +475,13 @@ describe('CollectionCacheService', () => {
expect(service.getCache('Main')).toEqual(mainTree);

await service.indexCollection('Admin', 'src/admin/i18n', 2);
expect(service.getCacheStatus('Main')).toBe(CacheStatus.NOT_STARTED);
expect(service.getCacheStatus('Main')).toBe(CacheStatus.READY);
expect(service.getCache('Main')).toEqual(mainTree);
expect(service.getCacheStatus('Admin')).toBe(CacheStatus.READY);
expect(service.getCache('Admin')).toEqual(adminTree);
});

it('should maintain only the latest indexed collection', async () => {
it('should keep the stats of each cached collection separate', async () => {
const mainTree = createMockTree(['main']);
const adminTree = createMockTree(['admin']);

Expand All @@ -425,18 +490,11 @@ describe('CollectionCacheService', () => {
.mockReturnValueOnce(mainTree.resources)
.mockReturnValueOnce(adminTree.resources);

// Index Main first
await service.indexCollection('Main', 'src/i18n', 3);
expect(service.getCacheStatus('Main')).toBe(CacheStatus.READY);
expect(service.getCache('Main')).toEqual(mainTree);

// Index Admin - should clear Main
await service.indexCollection('Admin', 'src/admin/i18n', 2);

expect(service.getCacheStatus('Admin')).toBe(CacheStatus.READY);
expect(service.getCache('Admin')).toEqual(adminTree);
expect(service.getCacheStatus('Main')).toBe(CacheStatus.NOT_STARTED);
expect(service.getCache('Main')).toBeNull();
expect(service.getCacheStats('Main')?.localeCount).toBe(3);
expect(service.getCacheStats('Admin')?.localeCount).toBe(2);
});

it('should handle error in one collection then successfully index another', async () => {
Expand All @@ -459,11 +517,11 @@ describe('CollectionCacheService', () => {
}
expect(service.getCacheStatus('Main')).toBe(CacheStatus.ERROR);

// Index Admin - should clear Main's error state and succeed
// Index Admin - Main keeps its own error state, Admin succeeds independently
await service.indexCollection('Admin', 'src/admin/i18n', 2);
expect(service.getCacheStatus('Admin')).toBe(CacheStatus.READY);
expect(service.getCache('Admin')).toEqual(adminTree);
expect(service.getCacheStatus('Main')).toBe(CacheStatus.NOT_STARTED);
expect(service.getCacheStatus('Main')).toBe(CacheStatus.ERROR);
});
});
describe('revalidate', () => {
Expand Down Expand Up @@ -544,7 +602,7 @@ describe('CollectionCacheService', () => {

writeEntries({ ok: { source: 'OK' }, maybe: { source: 'Maybe' } });
service.addResourceToCache('Main', createMockTree().resources[0], '');
service.refreshFingerprint();
service.refreshFingerprint('Main');

writeEntries({ ok: { source: 'OK' }, maybe: { source: 'Maybe' }, later: { source: 'Later' } });

Expand Down
Loading