VER-887: wifi: ath12k: handle XRETRY peer kickout as beacon loss for station mode#82
Merged
GadiAvr merged 2 commits intoMay 7, 2026
Conversation
There was a problem hiding this comment.
Pull request overview
Treats ath12k firmware “peer sta kickout” events with reason XRETRY (excessive TX retries) as a beacon-loss equivalent in station mode, so mac80211’s connection-loss flow is triggered rather than only reporting low ACK.
Changes:
- Adds
WMI_PEER_STA_KICKOUT_REASON_XRETRYto the kickout-reason switch cases that invokeath12k_mac_handle_beacon_miss()forNL80211_IFTYPE_STATION.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
adrian-nicolau
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause found: The firmware sends reason=1 (WMI_PEER_STA_KICKOUT_REASON_XRETRY — excessive TX retries) when the AP disappears, but the code only handled reason=2 (INACTIVITY) for beacon miss. XRETRY was falling through to default which just reports low ACK without triggering connection loss.
I added WMI_PEER_STA_KICKOUT_REASON_XRETRY as a case that also triggers ath12k_mac_handle_beacon_miss for station mode. This is the same approach used by ath10k/ath11k for the same scenario — when a station can't reach the AP (excessive retries), it should be treated as a lost connection.
It's working. The full flow is now correct:
The fix is: adding WMI_PEER_STA_KICKOUT_REASON_XRETRY to the case that triggers beacon miss handling for station mode.