Skip to content

chore: improve sigstore-python maintenance path#1788

Open
otjdiepluong wants to merge 1 commit into
sigstore:mainfrom
otjdiepluong:maint/20260525195747
Open

chore: improve sigstore-python maintenance path#1788
otjdiepluong wants to merge 1 commit into
sigstore:mainfrom
otjdiepluong:maint/20260525195747

Conversation

@otjdiepluong
Copy link
Copy Markdown

Summary:

  • Add focused unit tests for edge cases in the small helper functions in sigstore/_utils.py (e.g. base64 padding handling, PEM/DER conversion error paths, key id computation on empty/invalid inputs) to cover currently-untested error branches.
  • Keep the change narrow so it is straightforward to review.

Notes:

  • I kept this scoped to the relevant implementation and tests.

Copy link
Copy Markdown
Member

@woodruffw woodruffw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I don't understand the background content for this (and the PR title is very vague). Can you explain why you're submitting this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants