feat(time-input): add clear method and enhance validation behavior fo…#2551
Conversation
…r empty values Co-authored-by: Copilot <copilot@github.com>
🦋 Changeset detectedLatest commit: e6021f1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Code Review
This pull request adds a clear() method to the ix-time-input component and aligns its validation logic for required fields, novalidate forms, and dynamic attribute changes. Key feedback includes a suggestion to dynamically remove all validation classes during clear operations to ensure consistency, a request to justify or remove focus logic that might trigger unexpectedly during suppressed validation, and the removal of an unused utility function.
…ss removal logic Co-authored-by: Copilot <copilot@github.com>
…hen-value-is-empty-for-time-input
…for-time-input' of github.com:RamVinayMandal/ix into fix-ix-3322-display-input-as-valid-when-value-is-empty-for-time-input
|



💡 What is the current behavior?
ix-time-inputvalidation is not fully aligned when a value is removed after previous interaction.ix-time-inputdoes not provide a publicclear()method to clear the value and validation errors.novalidateand dynamicrequiredhandling are not fully aligned.GitHub Issue Number: #
🆕 What is the new behavior?
clear()method toix-time-inputto clear the value and validation errors.novalidate, and dynamicrequiredchanges.🏁 Checklist
A pull request can only be merged if all of these conditions are met (where applicable):
pnpm test)pnpm lint)pnpm build, changes pushed)👨💻 Help & support