Skip to content

feat: enable static libs for pcre2 - #562

Merged
talos-bot merged 1 commit into
siderolabs:mainfrom
frezbo:feat/build-pcre2-static-libs
Aug 3, 2026
Merged

feat: enable static libs for pcre2#562
talos-bot merged 1 commit into
siderolabs:mainfrom
frezbo:feat/build-pcre2-static-libs

Conversation

@frezbo

@frezbo frezbo commented Aug 3, 2026

Copy link
Copy Markdown
Member

enable static libs for pcre2, this allows us to
drop pcre2 from for qemu guest agent, since it's
built statically.

Copilot AI review requested due to automatic review settings August 3, 2026 15:41
@github-project-automation github-project-automation Bot moved this to To Do in Planning Aug 3, 2026
@talos-bot talos-bot moved this from To Do to In Review in Planning Aug 3, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Enables building PCRE2 static libraries in the tools-pcre2 package so downstream components (e.g., qemu guest agent/extensions) can link PCRE2 statically and avoid needing a runtime PCRE2 dependency.

Changes:

  • Switch PCRE2 build configuration from --disable-static to --enable-static.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tools-pcre2/pkg.yaml
enable static libs for pcre2, this allows us to
drop pcre2 from for qemu guest agent, since it's
built statically.

Signed-off-by: Noel Georgi <git@frezbo.dev>
@frezbo
frezbo force-pushed the feat/build-pcre2-static-libs branch from ce18b6f to c59cce5 Compare August 3, 2026 18:03
@github-project-automation github-project-automation Bot moved this from In Review to Approved in Planning Aug 3, 2026
@frezbo

frezbo commented Aug 3, 2026

Copy link
Copy Markdown
Member Author

/m

@talos-bot
talos-bot merged commit c59cce5 into siderolabs:main Aug 3, 2026
14 of 15 checks passed
@github-project-automation github-project-automation Bot moved this from Approved to Done in Planning Aug 3, 2026
@frezbo
frezbo deleted the feat/build-pcre2-static-libs branch August 3, 2026 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants