ci: drop legacy build-and-test.yml - #25
Merged
Merged
Conversation
This workflow is an exact functional duplicate of pr-checks.yml: the same npm ci -> lint -> build, then the same firebase-tools + serviceAccount + `npm run cov` on Node 20 and 22, written out as two hand-copied jobs instead of a matrix. It is also why autoupdate PRs could not be merged cleanly. Its emulator job stalls indefinitely -- observed twice in a row on the same commit, over an hour each time, while pr-checks ran the identical suite on that same commit in about two minutes. The workflow sets no timeout-minutes, so each stall burns the full 6-hour default. Nothing references it: it declares workflow_call but has no callers, and build-and-deploy.yml is dispatched by release-on-version-bump.yml rather than gated on this. firebase-engine is also the only one of the eight repos on the unified baseline still carrying the file -- the other seven have exactly autoupdate / claude / pr-checks / release-on-version-bump / build-and-deploy. This drops CI on pushes to master, since pr-checks deliberately ignores the default branch. That matches every sibling repo: changes are verified on the PR before merge. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PfHHX2WrotHCt9djnk6tMZ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes
.github/workflows/build-and-test.yml.Why
It is a duplicate. Job for job, it is
pr-checks.yml:build-and-test.ymlpr-checks.ymlnpm ci→npm run lint→npm run build→ archivelibnpm ci→npm run lint→npm run build→ archivedistnode20+node22, two hand-copied jobs:npm ci→ firebase-tools → serviceAccount →npm run covTest (Node 20/22)matrix:npm ci→ firebase-tools → serviceAccount →npm run covIt stalls. Its emulator job hangs indefinitely — observed twice in a row on commit
5228f71, over an hour each time, whilepr-checksran the identical suite on that same commit in ~2 minutes. It sets notimeout-minutes, so each stall burns the full 6-hour default. This is what left #23 without a clean verdict.Nothing depends on it. It declares
workflow_callbut has no callers anywhere in.github/. Releases gorelease-on-version-bump.yml→build-and-deploy.yml(tag dispatch) and never reference it.It is drift. Of the eight repos on the unified
autoupdate-with-claudebaseline, this is the only one still carrying the file. The other seven have exactlyautoupdate/claude/pr-checks/release-on-version-bump/build-and-deploy.Trade-off
build-and-test.ymlwas the only workflow running on pushes tomaster—pr-checks.ymlusespush: branches-ignore: [master]by design. After this,masterpushes get no CI, which is exactly how all seven sibling repos work: changes are verified on the PR before merge, andmasteronly advances through merged PRs.If you would rather keep post-merge verification on
master, the alternative is to addmasterback topr-checks.yml's push triggers instead — but that would diverge from the shared template, so I have not done it here.Generated by Claude Code