Repository navigation
add: sparshsingh0506 - #1286
Open
SparshSingh0506 wants to merge 1 commit into
Open
add: sparshsingh0506#1286SparshSingh0506 wants to merge 1 commit into
SparshSingh0506 wants to merge 1 commit into
Conversation
|
@SparshSingh0506 is attempting to deploy a commit to the Shyam Tawli's projects Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Great job, @SparshSingh0506! 🎉 Thank you for opening a pull request. Your contribution is valuable and we appreciate your efforts to improve our project.
Soon the maintainers/owner will review it and provide you with feedback/suggestions.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added my details in public/data/sparshsingh0506.json and github username in components/ProfileList.json as mentioned in the docs.
Checklist
Note to reviewers
This was my first contribution and I am glad to add my details to devFind!
Though, I had a little difficulty following the contribution steps because the README and CONTRIBUTING instructions have slightly different workflows. The branching step also appears a bit awkward to me, as one section suggests creating a branch after making changes, while another suggests creating it before making changes.
It might be helpful to make the steps consistent across both sections, especially for new contributors.
Thanks!