Repository navigation
Fix accessibility: ARIA labels, sr-only labels, aria-disabled, stable keys - #1285
Open
thesajidalam wants to merge 1 commit into
Open
thesajidalam wants to merge 1 commit into
thesajidalam wants to merge 1 commit into
Conversation
…able React keys - Add aria-label on social links (GitHub/Twitter/LinkedIn) with developer name - Add aria-label on theme toggle reflecting current mode - Add sr-only labels for search input and filter dropdown - Add aria-disabled on pagination buttons matching visual state - Add aria-label on Previous/Next pagination buttons - Remove invalid href attributes from span elements in Pagination - Replace array index keys with stable skill name keys in Profile - Fixes shyamtawli#1260, shyamtawli#1262
|
@thesajidalam is attempting to deploy a commit to the Shyam Tawli's projects Team on Vercel. A member of the Team first needs to authorize it. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Great job, @thesajidalam! 🎉 Thank you for opening a pull request. Your contribution is valuable and we appreciate your efforts to improve our project.
Soon the maintainers/owner will review it and provide you with feedback/suggestions.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1260 and #1262
Changes
Accessibility (Issue #1262)
aria-labelon GitHub, Twitter, and LinkedIn social links with the developer's name (e.g.,aria-label="GitHub profile of John Doe")aria-labelon theme toggle button reflecting current state ("Switch to dark mode"/"Switch to light mode")<label htmlFor>withsr-onlyclass for both the search criteria dropdown and search inputaria-disabledmatching visual disabled state,aria-labelon Previous/Next buttons, removed invalidhrefattributes from<span>elementsStable React Keys (Issue #1260)
key={index}(array index) withkey={skill}(stable string) for skill badgesAcceptance Criteria
hrefon non-anchor elements