Conversation
The ISO/IEC 18004 tables and bit-level primitives (codeword counts, block layout, the alphanumeric alphabet, alignment centers, the BCH format and Golay version words, GF(2^8), the mask predicates, popcount) had only one consumer, the QR encoder/decoder file. They now live at the top of qr.rip as its first section; nothing is exported, and the test suite reaches the six it pins through the `_tests` internals object like the other internals. Package tests 33/33; encoder oracle byte-identical on 1452 checks; decoder oracle identical on 192.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
spec.rip had one consumer, qr.rip. Its tables and primitives (codeword counts, block layout, alphanumeric alphabet, alignment centers, BCH format and Golay version words, GF(2^8), mask predicates, popcount) now open qr.rip as its first section, unexported. The test suite reaches the six it pins through the
_testsinternals object, like the other internals. The manifest's file list and the browser-safety test's file list drop the entry.Verification