Recover Rip access logs quietly after Janus restarts - #302
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restarting Janus drops its in-memory app registrations. Rip's access-log client retried the deleted IDs and printed every failed attempt, producing repeated socket errors and HTTP 404 diagnostics until the manager re-registered.
Stop retrying an ID after a 404 and wait for the manager to move the stream to its replacement registration. Report a repeated connection error once until a valid hello resets the diagnostic, while still reporting changed errors. Access streams and manager heartbeats share “Janus unavailable” diagnostics for known connection failures instead of Bun's misleading URL/port typo suggestion.
Validation: