Skip to content

Mentor button refactor #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dpinones merged 2 commits into from
Jul 17, 2025
Merged

Mentor button refactor #289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
314d69f
init&finish
LandauRaz Jul 16, 2025
c978882
minor fix
LandauRaz Jul 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/client/src/components/layout/About.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ export const About = () => {
};
return (
<>
<Tooltip title="About Starklings App">
<Tooltip title="About">
<IconButton
id="header-icon"
onClick={() => setDialogOpen(true)}
Expand Down
30 changes: 13 additions & 17 deletions app/client/src/components/layout/BasicLayout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@ import { GitHubLoginButton } from "../github/GitHubLoginButton";
import { About } from "./About";
import { useLocation, Link as RouterLink, useNavigate } from "react-router-dom";
import { useState } from "react";
import Tooltip from "@mui/material/Tooltip";
import IconButton from "@mui/material/IconButton";
import AssessmentIcon from "@mui/icons-material/Assessment";

const NAV_HEIGHT = "50px";

Expand Down Expand Up @@ -78,23 +81,16 @@ export const BasicLayout = ({ children }: IBasicLayoutProps) => {
</Link>
</Box>
<Box sx={{ display: "flex", gap: 1, alignItems: "center", mr: 2 }}>
<Button
onClick={handleMenuClick}
sx={{
color: "#FFF",
textTransform: "none",
fontSize: 14,
"&:hover": {
backgroundColor: "rgba(255, 255, 255, 0.08)",
},
display: "flex",
alignItems: "center",
gap: 0.5,
}}
>
<School sx={{ fontSize: 18 }} />
Mentor
</Button>
<Tooltip title="Assessment">
<IconButton
id="header-icon"
onClick={handleMenuClick}
sx={{ p: 0.5, color: "#FFF" }}
aria-label="about"
>
<AssessmentIcon />
</IconButton>
</Tooltip>
<Menu
anchorEl={anchorEl}
open={menuOpen}
Expand Down