Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SG-43166 Integrate MEDM authentication into Toolkit bootstrap #1100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: ticket/SG-43217/flow-data-sdk
Are you sure you want to change the base?
Uh oh!
There was an error while loading. Please reload this page.
SG-43166 Integrate MEDM authentication into Toolkit bootstrap #1100
Changes from all commits
37d75bc01b05b99f63cfecffb0e77fcd1f8dac96ba7a07f9b872d88f779a57a648a1051bb120044319fed24b615c6c84f30dc9568af6b3f59b834e3e601157File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
Check notice on line 15 in python/tank/authentication/flow_auth/_constants.py
generic-api-key
Check notice on line 16 in python/tank/authentication/flow_auth/_constants.py
internal_service.: https://api.aps.usa.autodesk.com
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will not import into python 3.10 without it, so we couldn't test inside Houdini.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this new? I don't remember us having these settings in env vars before?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They weren't in env vars before, they were set in the config.
We can change the way these are set later - this was just the simplest way to be able to override them to test auth against staging but have the prod values in the code.
It will be easier to fix this when we have a proper config set up and some code that uses all of this.
Uh oh!
There was an error while loading. Please reload this page.