Skip to content

Convert glamor to makestyles#1455

Open
AylinUenal wants to merge 99 commits intoCURB-5783-add-theme-supportfrom
CURB-5793-convert-glamor-to-makestyles
Open

Convert glamor to makestyles#1455
AylinUenal wants to merge 99 commits intoCURB-5783-add-theme-supportfrom
CURB-5793-convert-glamor-to-makestyles

Conversation

@AylinUenal
Copy link
Copy Markdown
Contributor

@AylinUenal AylinUenal commented Mar 19, 2026

Description

We are removing the glamor package by converting the glamor css to makeStyles. This is a preparation to adapt the components to the new theme.
This PR also converts class into functional components to provide a modern, maintainable code base.

Type of change

  • Bug Fix 🐛 (non-breaking change which fixes an issue)
  • Enhancement 🚀 (non-breaking change which adds functionality)
  • Breaking Change 💥 (fix or feature that would cause existing functionality to not work as expected)
  • Polish 💅 (Just some cleanups)
  • Internal 🏠 Only relates to internal processes.

@AylinUenal AylinUenal self-assigned this Mar 19, 2026
aylinuenal added 27 commits March 19, 2026 11:39
fkloes and others added 30 commits April 7, 2026 16:07
- fixed wrong background color of ios AddMoreButton from AddToCartBar
- reverted some AI changes for Headline of iOS theme and places where it's used
- removed usage of legacy context api
- fix order of applied classes in Button
- fix flickering when Dropdown opens for the first time
- fix styling issues in MessageBar
- fix missing hook dependencies in RangeSlider component
- add name to Typography styles
- clean up styles of StockInfo
…hopgate/pwa into CURB-5793-convert-glamor-to-makestyles
…hopgate/pwa into CURB-5793-convert-glamor-to-makestyles
- small component fixes where snapshots had missing properties compared to the not refactored versions
…mor-to-makestyles

# Conflicts:
#	libraries/commerce/product/selectors/product.js
#	libraries/engage/components/View/components/Content/index.jsx
- Fixed GMD NavDrawer Favlist badge styling
- Reverted Characteristic component back to class component since there was an issue with highlighting (kept styles from new system)
- Fixed Menu positioning via offset
- fixed text color of filter chips
- fixed some emotion warnings about usage of first-child
- fixed size of ios11 theme TabBar browse icon
- fixed some emotion warnings about usage of *-child pseudo classes
- fixed issues in migrated styles
…mmon/components

- removed Picker, ProductCharacteristics, RangeSlider and MessageBar (@shopgate/pwa-ui-shared)
- replaced by temporary components that wrap the corresponding components from @shopgate/engage with deprecation notices
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants