Symfony: expose public members of #[AsTwigComponent] classes to templates#366
Merged
Conversation
…ates
Twig components render their template with `this` bound to the
component instance, so every public property and method is reachable
from the template (e.g. `{{ this.getTranslatedTitle() }}`). Run such
classes through TemplateViewDataTraverser, the same machinery used
for data passed to render(), instead of requiring #[ExposeInTemplate].
Fixes #364
Co-Authored-By: Claude Code
janedbal
force-pushed
the
twig-component-public-members
branch
from
6a32cdc to
8a54227
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
thisbound to the component instance, so every public property and method is reachable from the template (e.g.{{ this.getTranslatedTitle() }}) — previously we required#[ExposeInTemplate]and reported such members as dead otherwise.SymfonyUsageProviderroutes#[AsTwigComponent]/#[AsLiveComponent]classes through the existingTemplateViewDataTraverser, the same machinery used for data passed torender(). Public members (and the classes they return) are marked as used.Fixes #364
Co-Authored-By: Claude Code