Treat array_column() string keys as property reads#362
Merged
Conversation
Closes #361 Co-Authored-By: Claude Code
mixed / object|array could be an array at runtime, in which case array_column reads array keys, not properties — don't poison the codebase by wildcard-marking every same-named property as used. Co-Authored-By: Claude Code
staabm
reviewed
May 18, 2026
| * | ||
| * @param array<Arg> $args | ||
| */ | ||
| private function registerArrayColumnPropertyReads( |
Contributor
There was a problem hiding this comment.
phpstan internally already tracks property reads and writes.
I wonder why you need such function specific custom implementations in this package
see e.g. ClassPropertiesNode
Member
Author
There was a problem hiding this comment.
property reads and writes in ClassPropertiesNode are usable only for private props really
Contributor
|
@janedbal would you mind tagging a new release? |
Member
Author
|
Tagged, 1.1.3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
column_key) and 3rd (index_key) string arguments ofarray_column()as property READs on the iterable value type of the 1st arg, when that element type is definitely an object.Closes #361