Report excluded usages via error tip instead of message suffix#360
Draft
ruudk wants to merge 1 commit into
Draft
Report excluded usages via error tip instead of message suffix#360ruudk wants to merge 1 commit into
ruudk wants to merge 1 commit into
Conversation
The "(all usages excluded by X excluder)" text was appended to the
error message itself, which mixed the diagnostic ("Unused X") with the
explanation of why it survived analysis. Moving it to a PHPStan error
tip keeps the message focused on the dead member and presents the
excluder context the same way transitive-death reasons are already
surfaced.
`BlackMember::getExclusionMessage()` becomes `getExclusionTip()`,
returning null when nothing is excluded, and `DeadCodeRule::buildError()`
emits it through `RuleErrorBuilder::addTip()` for both the representative
and transitively dead members.
Fixes shipmonk-rnd#359
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "(all usages excluded by X excluder)" text was appended to the error message itself, which mixed the diagnostic ("Unused X") with the explanation of why it survived analysis. Moving it to a PHPStan error tip keeps the message focused on the dead member and presents the excluder context the same way transitive-death reasons are already surfaced.
BlackMember::getExclusionMessage()becomesgetExclusionTip(), returning null when nothing is excluded, andDeadCodeRule::buildError()emits it throughRuleErrorBuilder::addTip()for both the representative and transitively dead members.Fixes #359