Repository navigation
Stills of a 2D composition render into a folder that doesn't exist yet, as before DR2 - #91
Merged
shinyobjectz merged 2 commits intoNov 10, 2026
Conversation
…t, as before DR2 Since bb0a176 every render writes its manifest beside its output, DIR/NAME.render.json for a folder of frames. A 2D composition's stills write the manifest before raea-render makes the folder and its frames, so with a DIR that didn't exist the render stopped before drawing anything: raea render edit.tsx --at 0 -o new-folder REFUSED new-folder/edit.render.json: The system cannot find the path specified. (os error 3) It worked into a folder that was already there, and for a composition with 3D, whose path makes the folder first. write_manifest now makes the manifest's folder before it writes. bench/at-0/check.sh and bench/svg-css-transform/check.sh render stills into a fresh temporary folder: both fail on main with the message above, and both pass with this (Windows 11). Co-Authored-By: Claude <noreply@anthropic.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
The first form chained the write after the folder with `.and_then(|()| std::fs::write(&path, m))`, which tools/dupes.sh reads as a copy of apps/check's hook.rs:105 (57 near-duplicate groups against the 56 allowed). The folder is now made first, in its own statement, and the write is as it was. The crate is still at its 2,000 lines: the manifest's JSON is written where it is built. Co-Authored-By: Claude <noreply@anthropic.com>
Owner
|
Merged, thanks: a clear cause, and two existing benches as the test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since bb0a176 (DR2), stills of a 2D composition fail when the output folder doesn't exist yet:
Nothing is drawn. It works into a folder that is already there, and for a composition with 3D.
Why
DR2 writes every render's manifest beside its output,
DIR/NAME.render.jsonfor a folder of frames. The 2D stills path callswrite_manifestbeforeraea_runtime_encode::rendermakes the folder and writes the frames, so the write has nowhere to go. Before DR2 there was no manifest unless--manifestasked for one. The 3D path makes the folder first, so it was not hit.Change
write_manifestmakes the manifest's folder before it writes.raea-runtime-exportis at its 2,000-line limit, so the change rewrites three lines and adds none.Two commits. The first chained the write after the folder with a closure that
tools/dupes.shreads as a copy of one inapps/check(57 near-duplicate groups against 56), and the gates job failed on it. The second makes the folder in a statement of its own.Testing
Two of the repo's own benches render stills into a fresh temporary folder, so they are the test:
bench/at-0/check.shbench/svg-css-transform/check.shRun on Windows 11 with a release build of each (
cargo build --release -p raea-cli --no-default-features),mainat bb0a176.tools/size.sh,layers.sh,names.sh,one-version.shandno-void.shpass on the branch, andcargo dupescounts the same groups as onmain. The same build also renders into a nested new folder, and with--manifestpointing into a folder that doesn't exist.Not run: macOS and Linux, though
std::fs::writeinto a missing folder fails the same way on both.cargo shearisn't installed here.The first commit was reviewed by GPT-6.1 Sol (high effort), a different model family from the one that wrote it: one round, no findings. The second commit has not been reviewed.
Created with Claude Fable 5.2 in T3 Code (Claude Code).
🤖 Generated with Claude Code