Skip to content

fingerprint: a render with no sound track has no sound to judge - #213

Merged
shinyobjectz merged 1 commit into
mainfrom
fp-silent
Nov 21, 2026
Merged

shinyobjectz merged 1 commit into
mainfrom
fp-silent

Conversation

@shinyobjectz

@shinyobjectz shinyobjectz commented Nov 21, 2026 •

Copy link
Copy Markdown
Owner

A render with no sound track was judged on the fingerprint's sound axes, and raea fingerprint score could hold it back as a gating dropout or clip over the whole file.

Cause

  • Columns::sound always embeds at least one clip, so a file that decodes to no samples still gets one empty clip's CLAP vector.
  • Modality::Sound.in_file only checked that the CLAP columns weren't empty, so it said the file had sound.

Fix

  • Sound and sound events count as present only when the file has levels to read. A file with no audio stream has none, in fresh columns and in the cache alike, so no cache needs clearing.
  • score is the only caller of in_file.
  • The embedding itself is unchanged, so evidence rows and damage windows keep their features.

Checked

  • A new test: a_file_with_no_sound_track_has_no_sound_to_judge.
  • On a real 10 s render with no audio stream, raea fingerprint score went from 5 moments (2 of them gating sound axes) to its 3 picture moments.

It came up while testing the fingerprint double check (AK8, #214), but it doesn't depend on it.

One thing worth knowing: the resident raea fingerprint serve keeps answering with the binary it was started from until it has been idle for 30 minutes, so a rebuilt or updated raea scores with old code until then (raea fingerprint stop ends it). The fix isn't in this PR.

Columns::sound embeds at least one clip, so a render with no audio stream
got one empty clip's CLAP vector, and Modality::Sound.in_file said it had
sound. Its sound axes then judged silence, and score could hold it back as a
gating dropout or clip over the whole file. Sound and sound events are now
in a file only when it has levels to read; the embedding is unchanged, so
evidence rows and damage windows keep their features.
@shinyobjectz
shinyobjectz merged commit a6f59c1 into main Nov 21, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant