Repository navigation
fingerprint: a render with no sound track has no sound to judge - #213
Merged
Merged
Conversation
Columns::sound embeds at least one clip, so a render with no audio stream got one empty clip's CLAP vector, and Modality::Sound.in_file said it had sound. Its sound axes then judged silence, and score could hold it back as a gating dropout or clip over the whole file. Sound and sound events are now in a file only when it has levels to read; the embedding is unchanged, so evidence rows and damage windows keep their features.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A render with no sound track was judged on the fingerprint's sound axes, and
raea fingerprint scorecould hold it back as a gating dropout or clip over the whole file.Cause
Columns::soundalways embeds at least one clip, so a file that decodes to no samples still gets one empty clip's CLAP vector.Modality::Sound.in_fileonly checked that the CLAP columns weren't empty, so it said the file had sound.Fix
scoreis the only caller ofin_file.Checked
raea fingerprint scorewent from 5 moments (2 of them gating sound axes) to its 3 picture moments.It came up while testing the fingerprint double check (AK8, #214), but it doesn't depend on it.
One thing worth knowing: the resident
raea fingerprint servekeeps answering with the binary it was started from until it has been idle for 30 minutes, so a rebuilt or updated raea scores with old code until then (raea fingerprint stopends it). The fix isn't in this PR.