Repository navigation
Windows: everything raea needs ships in bin\, under licences we can meet - #199
Merged
Merged
Conversation
…ase/ffmpeg-win.sh) raea ships FFmpeg beside raea.exe on Windows so a PC that can't download it still reads a phone's video. GyanD's essentials build, which raea fetched until now, is GPLv3 with a dozen GPL libraries linked in; shipping it would mean shipping all their sources. This build is FFmpeg's own code, zlib and libvpx's decoders (BSD, for alpha WebM, #113), static, LGPL 2.1 or later, with no capture devices and no network; its H.264 encoder is Windows' own through Media Foundation (h264_mf), since FFmpeg has none of its own and libx264 is GPL. Its complete source is FFmpeg's signed tarball, libvpx's tarball and this script. tools-ffmpeg.yml builds it with mingw-w64 (apt reading Ubuntu's archive, as the runner's own mirror trickled) and publishes it once as a prerelease with that source.
…ools/release/git-sources.sh) The Windows app ships dugite-native's Git for Windows (GPLv2) so a workspace is made on a PC without Git. GPLv2 section 3 asks whoever distributes it to make its complete corresponding source available, and dugite-native's repository alone isn't that: Git for Windows' MSYS2 runtime, bash, curl, OpenSSH and the rest are built from their own source packages. git-sources.sh resolves each package the build's etc/package-versions.txt names to the source package it came from (51: Git for Windows' pacman repository first, MSYS2's source mirror for the rest) and packs them with the list; tools-git-sources.yml publishes that once as the prerelease tools-git-<tag>-sources, which the app's git\SOURCE.txt names.
…fmpeg::h264) raea notes check's sign-off clip and a postmortem's clip were cut with libx264, which only a GPL ffmpeg has: Homebrew's and Linux distributions' do, and GyanD's Windows build did, but the LGPL build raea now ships on Windows doesn't. h264() asks ffmpeg -encoders once and takes libx264, else Windows' own Media Foundation encoder (h264_mf, in raea's LGPL build), else VideoToolbox's, at 8 Mb/s for the system ones; None without one (notes check says so; a postmortem plays the whole piece, as it did when a cut failed).
… and no downloads works tools/release/win-bundle.sh puts beside raea.exe, each with its licence: Microsoft's Visual C++ runtime (vcruntime140, vcruntime140_1, msvcp140, msvcp140_1) from the runner's Visual Studio, app-local as Microsoft documents; raea's LGPL FFmpeg 9.0.2 (tools-ffmpeg-9.0.2-lgpl, libvpx's licence and patent grant beside it); and uv. Before, raea.exe didn't start without the VC++ Redistributable installed, and a PC that blocks GitHub's downloads couldn't read a phone's video or set up a local model. Its pins are setup.rs's, so what ships and what raea fetches where it isn't are the same build: setup.rs now fetches our LGPL zip (sha256 d3a3d8cd...) in place of GyanD's GPL essentials. release.yml runs it, and release-check.sh refuses a Windows zip whose bin\ lacks a file win-bundle.files lists, whose FFmpeg isn't the LGPL build, or that has no libvpx-vp9 or h264_mf. NOTICE, the README and 0.1.8's what's new say so. Checked on the Windows box with the published zip: LGPL, the libvpx VP8/VP9 decoders and h264_mf listed; a 2 s H.264 clip with AAC cut by h264_mf at notes check's arguments; an alpha VP9 WebM decoded with its alpha (253,0,0,127); the filters raea runs (ebur128, freezedetect, signalstats, scale, concat, showwavespic, ...) present.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A PC with nothing installed and no downloads (a work PC that blocks GitHub) now starts raea, reads a phone's video and sets up a local model.
tools/release/ffmpeg-win.sh,tools-ffmpeg.yml). It is built from FFmpeg 9.0.2's signed release with mingw-w64: FFmpeg's own code, zlib and libvpx 1.17.0's decoders (BSD, for alpha WebM, Video with an alpha channel: VP9 WebM is refused ("no video track"), ProRes 4444 is drawn opaque #113). There are no capture devices and no network. Its H.264 encoder is Windows' own, through Media Foundation (h264_mf). The build is published once, with its complete source, as the prereleasetools-ffmpeg-9.0.2-lgpl(zip sha256d3a3d8cd…). It replaces GyanD's GPLv3 essentials build, which we couldn't ship.raea_io_ffmpeg::h264): libx264, else h264_mf, else VideoToolbox.raea notes checkand a postmortem's clip used libx264 only.tools/release/win-bundle.sh,win-bundle.files).setup.rsfetches the same pinned builds where they're missing.tools/release/git-sources.sh).Checked on a Windows PC with the published zip:
cargo test -p raea-io-assetspasses (12 tests).🤖 Generated with Claude Code