Repository navigation
Setup: a fetch stopped partway no longer leaves its download behind - #193
Merged
Merged
Conversation
uv's and FFmpeg's fetches download into NAME.part<pid> and move it in when it's whole. A fetch stopped partway (a Ctrl+C, a closed window, a killed process) left its part folder, and every later fetch made a new one: on a Windows test box three were left beside FFmpeg, one holding the 114 MB zip. Both fetches now end through one settle(): the part moved in when it's whole and nothing got there first, the part removed, and once the tool is in place every NAME.part* beside it swept. A part another process is still writing stays on Windows (its open file can't be removed); elsewhere that fetch fails, finds the tool in place, and counts as done, as a failed fetch that finds the tool already does. settle_sweeps_stopped_fetches: two stopped FFmpeg parts and this run's are swept while uv's is kept, a failed fetch that finds the tool is done, and one that doesn't says why.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
uv's and FFmpeg's fetches download into
NAME.part<pid>and move it in when it's whole. A fetch stopped partway left its part folder behind: a Ctrl+C, a closed window or a killed process. Every later fetch then made a new one. On the Windows test box, rc7's run found three beside FFmpeg, one holding the 114 MB zip.Both fetches now end through one
settle():NAME.part*beside it is swept.A part another process is still writing stays on Windows, where its open file can't be removed. Elsewhere, that other fetch fails, finds the tool in place and counts as done, as a failed fetch that finds the tool already does.
settle_sweeps_stopped_fetcheschecks three things:Checked:
cargo test -p raea-io-assetspasses, the crate builds forx86_64-pc-windows-msvc, and the gates pass (size, dupes, layers, names, one-version, no-void, taxonomy, rask).🤖 Generated with Claude Code