Skip to content

Setup: a fetch stopped partway no longer leaves its download behind - #193

Merged
shinyobjectz merged 1 commit into
mainfrom
fetch-sweep
Nov 19, 2026
Merged

shinyobjectz merged 1 commit into
mainfrom
fetch-sweep

Conversation

@shinyobjectz

Copy link
Copy Markdown
Owner

uv's and FFmpeg's fetches download into NAME.part<pid> and move it in when it's whole. A fetch stopped partway left its part folder behind: a Ctrl+C, a closed window or a killed process. Every later fetch then made a new one. On the Windows test box, rc7's run found three beside FFmpeg, one holding the 114 MB zip.

Both fetches now end through one settle():

  • the part is moved in when it's whole and nothing got there first;
  • the part is removed;
  • once the tool is in place, every NAME.part* beside it is swept.

A part another process is still writing stays on Windows, where its open file can't be removed. Elsewhere, that other fetch fails, finds the tool in place and counts as done, as a failed fetch that finds the tool already does.

settle_sweeps_stopped_fetches checks three things:

  • two stopped FFmpeg parts and this run's part are swept, while uv's is kept;
  • a failed fetch that finds the tool is done;
  • one that doesn't find it says why.

Checked: cargo test -p raea-io-assets passes, the crate builds for x86_64-pc-windows-msvc, and the gates pass (size, dupes, layers, names, one-version, no-void, taxonomy, rask).

🤖 Generated with Claude Code

uv's and FFmpeg's fetches download into NAME.part<pid> and move it in when it's whole. A fetch stopped partway (a Ctrl+C, a closed window, a killed process) left its part folder, and every later fetch made a new one: on a Windows test box three were left beside FFmpeg, one holding the 114 MB zip.

Both fetches now end through one settle(): the part moved in when it's whole and nothing got there first, the part removed, and once the tool is in place every NAME.part* beside it swept. A part another process is still writing stays on Windows (its open file can't be removed); elsewhere that fetch fails, finds the tool in place, and counts as done, as a failed fetch that finds the tool already does.

settle_sweeps_stopped_fetches: two stopped FFmpeg parts and this run's are swept while uv's is kept, a failed fetch that finds the tool is done, and one that doesn't says why.
@shinyobjectz
shinyobjectz merged commit 0112793 into main Nov 19, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant