Repository navigation
#182: no Engine makes an event loop, in any build, so 3D renders on Linux - #183
Merged
Merged
Conversation
…inux raea's headless Engines (raea-render's, the page's BlitzPage) left Bevy's WinitPlugin out only when a registered plugin that brought bevy_winit said so (hanabi's x11, raea-page-host's window). A build that brought it some other way, cargo unifying features across `-p raea-cli -p raea-page-host --features raea-page-host/window` or the whole workspace, kept it on: each App made an event loop, winit allows one a process, and every 3D render and play panicked "Failed to build event loop: RecreationAttempt" on Linux (with no display: "neither WAYLAND_DISPLAY nor ... DISPLAY is set"), while a page rendered. raea-runtime-plugins now compiles bevy_winit in on the desktop (x11 on Linux, loaded at run time, never opened) and its group() always leaves WinitPlugin out, however the build brought it. The lockfile already held the graph (winit was in for raea play's window). A unit test says so on macOS and Ubuntu (CI's test list), and the release archive check renders a 3D frame on Linux and macOS, on Linux once more with no display: no release step had rendered 3D on Linux.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #182.
What broke. raea's headless Engines (raea-render's, and the page's BlitzPage) left Bevy's
WinitPluginout only when a registered plugin that broughtbevy_winitsaid so: hanabi'sx11hook, and raea-page-host's window hook. A build that broughtbevy_winitin some other way kept the plugin on. One such build is cargo unifying features across-p raea-cli -p raea-page-host --features raea-page-host/window; a whole-workspace build is another. Each App then made an event loop, and winit allows one per process. On Linux every 3D render and play panicked withFailed to build event loop: RecreationAttempt, while page compositions rendered. With no display the first attempt failed instead:neither WAYLAND_DISPLAY nor WAYLAND_SOCKET nor DISPLAY is set. Both match the report.The releases weren't affected: their plugin catalog includes hanabi, whose hook turns the plugin off. rc3's Linux archive rendered
examples/games/shapes.tsxunder Xvfb, under headless Wayland (weston) and with no display.The fix. raea-runtime-plugins compiles
bevy_winitin on desktop targets (x11 on Linux: loaded at run time, never opened), andgroup()always leavesWinitPluginout, however the build brought it. The lockfile already held this graph, since winit was already in forraea play's window, so--lockedbuilds are unchanged.Tests
an_engine_makes_no_event_loop(runtime/plugins), added to CI's test list on macOS and Ubuntu.tools/release-check.sh) now renders a 3D frame on Linux and macOS, and on Linux renders it again with no display. No release step had rendered 3D on Linux before. The scene is on black, so a 3D pass that drew nothing trips raea's all-black check.probe-182branch's workflow.🤖 Generated with Claude Code