Repository navigation
FC1c: live play keeps a material's animated fields and a shader's time moving past the first frame - #177
Merged
Conversation
…e moving past the first frame LT21 (a3fec64) let live play's fast path keep component rows as they were sent while scene_sig, made of the lights and each part's <BevyComponent>s, stayed the same. A material's animate of a field past the row columns' four (material_fields) and a ThreeShaderMaterial's uniforms, time and textures (three_uniforms) are component rows too, but weren't in the sig, so after the first frame nothing sent them again: the glowing cube in bevy-ts's material-field-live stayed red where frame 25 is dark. v0.1.8-rc1's Windows release job failed on it, and the Mac does the same. scene_sig now takes every source of component rows: the components, a material's field: props and a shader's uniforms, time and textures. A frame where none of them changed keeps LT21's fast path. Measured on the Mac with the fix: bevy-ts's play cases 12 pass (material-field-live included); live-plugin needs the plugin build's avian, which the release zip has. raea-runtime-look's tests: 12 pass, one new.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v0.1.8-rc1's Windows release job failed on bevy-ts's
material-field-live(run 44339025119): the glowing cube stayed red at frame 25, where it should be dark. The Mac does the same, so it's a regression since v0.1.7, not the runner.Cause. LT21 (a3fec64) let live play's fast path keep component rows as sent while
scene_sig(the lights and each part's<BevyComponent>s) stayed the same. A material's animated fields past the row columns (material_fields) and a ThreeShaderMaterial's uniforms, time and textures (three_uniforms) are component rows too, but weren't in the sig, so nothing sent them again after the first frame.Fix.
scene_sigtakes every source of component rows. A frame where none of them changed keeps LT21's fast path.Checked on the Mac. bevy-ts's play cases: 12 pass,
material-field-liveincluded (live-pluginneeds the plugin build's avian, which the release zip has).raea-runtime-look's tests: 12 pass, one new.🤖 Generated with Claude Code