Skip to content

FC1c: live play keeps a material's animated fields and a shader's time moving past the first frame - #177

Merged
shinyobjectz merged 1 commit into
mainfrom
fc1c-live-fields
Nov 18, 2026
Merged

shinyobjectz merged 1 commit into
mainfrom
fc1c-live-fields

Conversation

@shinyobjectz

Copy link
Copy Markdown
Owner

v0.1.8-rc1's Windows release job failed on bevy-ts's material-field-live (run 44339025119): the glowing cube stayed red at frame 25, where it should be dark. The Mac does the same, so it's a regression since v0.1.7, not the runner.

Cause. LT21 (a3fec64) let live play's fast path keep component rows as sent while scene_sig (the lights and each part's <BevyComponent>s) stayed the same. A material's animated fields past the row columns (material_fields) and a ThreeShaderMaterial's uniforms, time and textures (three_uniforms) are component rows too, but weren't in the sig, so nothing sent them again after the first frame.

Fix. scene_sig takes every source of component rows. A frame where none of them changed keeps LT21's fast path.

Checked on the Mac. bevy-ts's play cases: 12 pass, material-field-live included (live-plugin needs the plugin build's avian, which the release zip has). raea-runtime-look's tests: 12 pass, one new.

🤖 Generated with Claude Code

…e moving past the first frame

LT21 (a3fec64) let live play's fast path keep component rows as they were sent while scene_sig, made of the lights
and each part's <BevyComponent>s, stayed the same. A material's animate of a field past the row columns' four
(material_fields) and a ThreeShaderMaterial's uniforms, time and textures (three_uniforms) are component rows too, but
weren't in the sig, so after the first frame nothing sent them again: the glowing cube in bevy-ts's material-field-live
stayed red where frame 25 is dark. v0.1.8-rc1's Windows release job failed on it, and the Mac does the same.

scene_sig now takes every source of component rows: the components, a material's field: props and a shader's
uniforms, time and textures. A frame where none of them changed keeps LT21's fast path.

Measured on the Mac with the fix: bevy-ts's play cases 12 pass (material-field-live included); live-plugin needs the
plugin build's avian, which the release zip has. raea-runtime-look's tests: 12 pass, one new.
@shinyobjectz
shinyobjectz merged commit 5194d34 into main Nov 18, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant